Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some more deprecation fixes #646

Merged
merged 3 commits into from
Feb 22, 2018
Merged

Some more deprecation fixes #646

merged 3 commits into from
Feb 22, 2018

Conversation

fredrikekre
Copy link
Member

No description provided.

@@ -34,6 +34,10 @@ else
using Base: ip_matches_func
end

@static if VERSION >= v"0.7.0-DEV.3656"
import Pkg
end
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't import Compat: Pkg work?

@fredrikekre
Copy link
Member Author

Unrelated nightly windows failure, requires admin to merge.

@mortenpi mortenpi added this to the 0.14.0 milestone Feb 22, 2018
@mortenpi mortenpi merged commit b957845 into master Feb 22, 2018
@mortenpi
Copy link
Member

Thanks! You would also want a tag soon-ish I guess?

@mortenpi mortenpi deleted the fe/deprecations branch February 22, 2018 23:13
@fredrikekre
Copy link
Member Author

You would also want a tag soon-ish I guess?

No hurry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants