Add support for FTP in linkcheck, disable other protocols #879
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iamed2
force-pushed
the
ed/ftp-linkcheck
branch
from
26d1acb to
d193b77
Compare
mortenpi
requested changes
Nov 3, 2018
iamed2
force-pushed
the
ed/ftp-linkcheck
branch
from
d193b77 to
746a25d
Compare
iamed2
force-pushed
the
ed/ftp-linkcheck
branch
from
746a25d to
ae9b39a
Compare
fredrikekre
approved these changes
Nov 6, 2018
mortenpi
reviewed
Nov 6, 2018
mortenpi
approved these changes
Nov 6, 2018
mortenpi
added a commit
that referenced
this pull request
Dec 1, 2018
mortenpi
added a commit
that referenced
this pull request
Dec 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #873 ?
This adds support for FTP as well as some tests, and causes unsupported protocols to fail when running curl vs at parse time.