Setting ans to a expression in REPLBlocks. #926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mortenpi
changed the title
|
Seems to work, so LGTM. It might be good to test against Base doctests before the release, just in case. Could use a CHANGELOG entry, but were thinking about adding them later all at once? |
|
Also, it might be good to drop the previously failing example into |
fredrikekre
force-pushed
the
fe/repl-block
branch
from
87cc2a5 to
416f939
Compare
fredrikekre
force-pushed
the
fe/repl-block
branch
from
416f939 to
e7a6fe5
Compare
|
Done. |
mortenpi
approved these changes
Jan 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #923