Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggest name for public key too #61

Merged
merged 4 commits into from
Jul 24, 2022
Merged

Conversation

rikhuijzer
Copy link
Contributor

For consistency with the suggestion for the private key name in the code here and for consistency with many tutorials which advice setting DOCUMENTER_PUB.

@mortenpi
Copy link
Member

mortenpi commented Jul 18, 2022

Actually, it should not be necessary to give it a title at all. We set -C Documenter, so you should get something like

ssh-rsa AAAAB...z714rOGBK10= Documenter

And, if I remember correctly, GitHub uses that key comment as the name if the "Title" field is left empty.

@rikhuijzer
Copy link
Contributor Author

And, if I remember correctly, GitHub uses that key comment as the name if the "Title" field is left empty.

I had no idea about that. Maybe we can incorporate that in the text without being too verbose? Otherwise, feel free to close this PR.

@mortenpi
Copy link
Member

Maybe we can incorporate that in the text without being too verbose?

Yeah, that's a good idea. Happy to take suggestions on how to rephrase it 🙂

@rikhuijzer
Copy link
Contributor Author

And, if I remember correctly, GitHub uses that key comment as the name if the "Title" field is left empty.

I just tested it and it indeed it works.

I've rephrased the sentence and put the sentence in the order of the fields in the GitHub interface.

src/genkeys.jl Outdated Show resolved Hide resolved
rikhuijzer and others added 2 commits July 24, 2022 11:52
@rikhuijzer rikhuijzer requested a review from mortenpi July 24, 2022 09:53
@mortenpi mortenpi merged commit 15f29aa into JuliaDocs:master Jul 24, 2022
@mortenpi
Copy link
Member

Thanks @rikhuijzer!

@rikhuijzer rikhuijzer deleted the patch-1 branch July 24, 2022 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants