Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add foldername kwarg to servedocs #100

Merged
merged 2 commits into from
Jun 3, 2020

Conversation

cserteGT3
Copy link
Contributor

As discussed in #99. For documentation: is the record in the docstrings enough?
For tests I shamelessly copied the testsets and modified them, hope it's fine.

@@ -10,9 +10,10 @@ triggered to regenerate the documents, subsequently the LiveServer will render t
in `docs/build`.
"""
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the function signature & add a short note about folder name being the name of the folder if not docs

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad, forgot the signatures.

src/utils.jl Outdated
@@ -117,9 +118,11 @@ assumed that they are in `docs/src`.
* `doc_env=false` is a boolean switch to make the server start by activating the doc environment or not (i.e. the `Project.toml` in `docs/`).
* `skip_dir=""` is a subpath of `docs/` where modifications should not trigger the generation of the docs, this is useful for instance if you're using Weave and Weave generates some files in `docs/src/examples` in which case you should give `skip_dir=joinpath("docs","src","examples")`.
* `skip_dirs=[]` same as `skip_dir` but for a vector of such dirs. Takes precedence over `skip_dir`.
* `foldername="docs"` use `foldername` instead of "docs" everywhere.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(use ... everywhere) --> specify the name of the content folder if different than "docs"`.

@codecov-commenter
Copy link

codecov-commenter commented Jun 3, 2020

Codecov Report

Merging #100 into master will not change coverage.
The diff coverage is 69.23%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #100   +/-   ##
=======================================
  Coverage   88.53%   88.53%           
=======================================
  Files           4        4           
  Lines         218      218           
=======================================
  Hits          193      193           
  Misses         25       25           
Impacted Files Coverage Δ
src/utils.jl 78.37% <69.23%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 85d2aac...300c7d6. Read the comment docs.

@tlienart
Copy link
Collaborator

tlienart commented Jun 3, 2020

This looks great, many thanks!

Could you please lightly update the docs? (man/functionalities/) the additional keyword sections

Then I'll merge and do a minor release with it, thanks!

@tlienart
Copy link
Collaborator

tlienart commented Jun 3, 2020

Thanks Tamás!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants