Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When returning 404, look for /404/ and /404.html and serve as the response body. #107

Merged
merged 1 commit into from
Aug 25, 2020

Conversation

fredrikekre
Copy link
Member

No description provided.

and serve as the response body.
@codecov-commenter
Copy link

codecov-commenter commented Aug 24, 2020

Codecov Report

Merging #107 into master will increase coverage by 0.60%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #107      +/-   ##
==========================================
+ Coverage   88.53%   89.14%   +0.60%     
==========================================
  Files           4        4              
  Lines         218      221       +3     
==========================================
+ Hits          193      197       +4     
+ Misses         25       24       -1     
Impacted Files Coverage Δ
src/server.jl 90.90% <100.00%> (+0.38%) ⬆️
src/utils.jl 79.45% <0.00%> (+1.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 490a06c...a765348. Read the comment docs.

@tlienart
Copy link
Collaborator

Thanks a lot! Lgtm from a quick look, I'll have a second look when I'm on my laptop and will try to merge tomorrow.

@tlienart tlienart merged commit c940748 into JuliaDocs:master Aug 25, 2020
@fredrikekre fredrikekre deleted the fe/custom-404 branch August 25, 2020 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants