Fix redirection and file path handling for URL with query strings #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkf
commented
Oct 6, 2020
| fs_path = joinpath(r_parts...) | ||
| if !isempty(CONTENT_DIR[]) | ||
| fs_path = joinpath(CONTENT_DIR[], fs_path) | ||
| end | ||
| # if no file is specified, try to append `index.html` and see | ||
| endswith(req_path, "/") && (fs_path = joinpath(fs_path, "index.html")) | ||
| endswith(uri.path, "/") && (fs_path = joinpath(fs_path, "index.html")) |
There was a problem hiding this comment.
@fredrikekre Thanks for the pointer! tlienart/Franklin.jl#641 (comment)
Codecov Report
@@ Coverage Diff @@
## master #111 +/- ##
==========================================
+ Coverage 85.55% 85.76% +0.21%
==========================================
Files 4 4
Lines 263 267 +4
==========================================
+ Hits 225 229 +4
Misses 38 38
Continue to review full report at Codecov.
|
|
Thanks a lot! I'll look into how you tackled this a bit later and will merge 🙌🏼 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #110
Changes:
/a/b?c=dis redirected to/a/b/?c=d/a/b/?c=dserves/a/b/index.html