Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused type variable from roundval #372

Merged
merged 1 commit into from
Dec 9, 2022
Merged

Remove unused type variable from roundval #372

merged 1 commit into from
Dec 9, 2022

Conversation

KnutAM
Copy link
Contributor

@KnutAM KnutAM commented Dec 9, 2022

Ref JuliaLang/julia#29393 even though performance might not be so important here, at least the warning is suppressed

@codecov
Copy link

codecov bot commented Dec 9, 2022

Codecov Report

Merging #372 (10c4586) into main (890c9f1) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #372   +/-   ##
=======================================
  Coverage   91.18%   91.18%           
=======================================
  Files           8        8           
  Lines         749      749           
=======================================
  Hits          683      683           
  Misses         66       66           
Impacted Files Coverage Δ
src/naming.jl 94.85% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Datseris Datseris merged commit f833de7 into JuliaDynamics:main Dec 9, 2022
@KnutAM KnutAM deleted the kam/unusedtypedeclaration branch December 9, 2022 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants