Update README #106
Merged
Update README #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
EricForgy
commented
May 27, 2020
EricForgy
commented
- Add Pkg to Project.yoml
- Fix path in build.jl
- _currencies -> _currency_data in constructor
- Add alldata() and change allsyms() -> allsymbols()
- Add test of data length
- Add Pkg to Project.yoml - Fix path in build.jl - _currencies -> _currency_data in constructor - Add alldata() and change allsyms() -> allsymbols() - Add test of data length
ScottPJones
reviewed
May 27, 2020
src/Currencies.jl
Outdated
| @@ -65,7 +65,8 @@ unit(::Currency{S}) where {S} = unit(S) | |||
| code(::Currency{S}) where {S} = code(S) | |||
| name(::Currency{S}) where {S} = name(S) | |||
|
|
|||
| allsyms() = keys(_currency_data) | |||
| alldata() = _currency_data | |||
There was a problem hiding this comment.
This is kind of dangerous, as far as encapsulation.
That's why I have the "allpairs", that has a defined interface (an iterator producing pairs of key => values)
test/runtests.jl
Outdated
| @@ -21,6 +21,7 @@ end | |||
|
|
|||
| # This makes sure that the values are within expected ranges | |||
| @testset "Validation" begin | |||
| @test length(_currency_data) == 155 | |||
There was a problem hiding this comment.
This should definitely not be there. You might want to test that there are at least 155, because I doubt that a currency would be removed from the table, but not that it is precisely 155.
EricForgy
pushed a commit
that referenced
this pull request
May 27, 2020
* Update tests and build process * Further updates to build process * Add pre-built currency data file * Update README (#106) * Update README - Add Pkg to Project.yoml - Fix path in build.jl - _currencies -> _currency_data in constructor - Add alldata() and change allsyms() -> allsymbols() - Add test of data length * Remove alldata() and add test >= 155 Co-authored-by: Eric Forgy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.