Custom definition for `append!!(_, Init(append!!))` #148

tkf · 2020-05-23T23:22:43Z

Using the default approach InitialValues.@def_monoid monoid!! was problematic because defining monoid!!(::CustomType, x) introduced method ambiguities. It could be solved semi-automatically by @disambiguate append!! CustomType but it is very ugly and very problematic for the extensibility of the method.

Furthermore, the definition

append!!(::InitAppend!!, src) = src

that is generated by @def_monoid is not appropriate if src should be consumed by the time append!! is called (e.g., https://discourse.julialang.org/t/38845/3). This is mostly the case since the returned value of monoid!!(init, src) would be used as the first argument (i.e., it would be mutated) in the "next iteration" in reduction code idioms. That is to say, monoid!! should not assume the ownership of the second argument.

The method ambiguity problem is solved by introducing a "dispatch pipeline"; i.e., a CustomType implementer can overload __monoid!!__ instead of monoid!!.

The memory ownership problem is solved by defining InitialValues.jl interface manually. For example, append!!(::InitAppend!!, src) now calls copymutable(src).

Alternative approach

For append!!, an alternative approach considered is to create a custom EmptyCollection type that behaves like "an" identity element of append!!. This may be possible by allowing InitialValues.Init(::typeof(monoid!!)) overload. This approach has some nice properties:

No need to define append!!(::Any, ::InitType) as it would work via the default implementation of append!! based on iterator. (The flip-side is that a bug could be hidden if the init object is fed to other functions like collect. But this is not a serious problem.)
By using the trait mechanism and defining NoBang.append, append!! would behave as expected without any "surface" dispatches.

A major downside of this approach is that the fold code does not have a canonical way to check if monoid!! is ever called. If overloading InitialValues.Init were supported, the fold implementers cannot simply call acc isa InitialValue to check if acc = monoid!!(acc, x) was called at least once.

Commit Message

Custom definition for append!!(_, Init(append!!)) (#148)

Implement a better fix for the method ambiguity problem of
append!!(_, Init(append!!)). Also fix the ownership problem of
append!!(Init(append!!), xs) by copying xs.

Using commit: Add `INIT` that works with arbitrary operators JuliaFolds/InitialValues.jl@b5b0777

codecov-commenter · 2020-05-23T23:27:55Z

Codecov Report

Merging #148 into master will decrease coverage by 0.13%.
The diff coverage is 87.50%.

@@            Coverage Diff             @@
##           master     #148      +/-   ##
==========================================
- Coverage   92.11%   91.98%   -0.14%     
==========================================
  Files          21       22       +1     
  Lines         444      449       +5     
==========================================
+ Hits          409      413       +4     
- Misses         35       36       +1

Impacted Files	Coverage Δ
src/initials.jl	`75.00% <75.00%> (ø)`
src/base.jl	`83.15% <100.00%> (+0.17%)`	⬆️
src/collectors.jl	`100.00% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 69d6a64...0b7d641. Read the comment docs.

github-actions · 2020-05-23T23:31:19Z

Benchmark result

Judge result

Benchmark Report for /home/runner/work/BangBang.jl/BangBang.jl

Job Properties

Time of benchmarks:
- Target: 23 May 2020 - 23:29
- Baseline: 23 May 2020 - 23:31
Package commits:
- Target: 8ff9db
- Baseline: 69d6a6
Julia commits:
- Target: 381693
- Baseline: 381693
Julia command flags:
- Target: None
- Baseline: None
Environment variables:
- Target: None
- Baseline: None

Results

A ratio greater than 1.0 denotes a possible regression (marked with ❌), while a ratio less
than 1.0 denotes a possible improvement (marked with ✅). Only significant results - results
that indicate possible regressions or improvements - are shown below (thus, an empty table means that all
benchmark results remained invariant between builds).

ID	time ratio	memory ratio
`["collectors", ":comp => \"map\"", ":impl => \"coll\""]`	0.83 (5%) ✅	1.00 (1%)
`["collectors", ":comp => \"map\"", ":impl => \"man\""]`	1.06 (5%) ❌	1.00 (1%)
`["dataframes", "Categorical"]`	0.81 (5%) ✅	1.00 (1%)
`["dataframes", "Missing-Int"]`	1.05 (5%) ❌	1.00 (1%)

Benchmark Group List

Here's a list of all the benchmark groups executed by this job:

["append"]
["collectors", ":comp => \"filter\""]
["collectors", ":comp => \"map\""]
["dataframes"]

Julia versioninfo

Target

Julia Version 1.4.1
Commit 381693d3df* (2020-04-14 17:20 UTC)
Platform Info:
  OS: Linux (x86_64-pc-linux-gnu)
      Ubuntu 18.04.4 LTS
  uname: Linux 5.3.0-1020-azure #21~18.04.1-Ubuntu SMP Wed Apr 15 09:35:56 UTC 2020 x86_64 x86_64
  CPU: Intel(R) Xeon(R) CPU E5-2673 v4 @ 2.30GHz: 
              speed         user         nice          sys         idle          irq
       #1  2294 MHz      18650 s          0 s       1422 s      14578 s          0 s
       #2  2294 MHz       8276 s          0 s       1344 s      24631 s          0 s
       
  Memory: 6.764888763427734 GB (3594.48046875 MB free)
  Uptime: 358.0 sec
  Load Avg:  1.03271484375  0.75439453125  0.3564453125
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-8.0.1 (ORCJIT, broadwell)

Baseline

Julia Version 1.4.1
Commit 381693d3df* (2020-04-14 17:20 UTC)
Platform Info:
  OS: Linux (x86_64-pc-linux-gnu)
      Ubuntu 18.04.4 LTS
  uname: Linux 5.3.0-1020-azure #21~18.04.1-Ubuntu SMP Wed Apr 15 09:35:56 UTC 2020 x86_64 x86_64
  CPU: Intel(R) Xeon(R) CPU E5-2673 v4 @ 2.30GHz: 
              speed         user         nice          sys         idle          irq
       #1  2294 MHz      26462 s          0 s       1547 s      16318 s          0 s
       #2  2294 MHz      10032 s          0 s       1460 s      32458 s          0 s
       
  Memory: 6.764888763427734 GB (3572.8203125 MB free)
  Uptime: 455.0 sec
  Load Avg:  1.02392578125  0.837890625  0.427734375
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-8.0.1 (ORCJIT, broadwell)

Target result

Benchmark Report for /home/runner/work/BangBang.jl/BangBang.jl

Job Properties

Time of benchmark: 23 May 2020 - 23:29
Package commit: 8ff9db
Julia commit: 381693
Julia command flags: None
Environment variables: None

Results

Below is a table of this job's results, obtained by running the benchmarks.
The values listed in the ID column have the structure [parent_group, child_group, ..., key], and can be used to
index into the BaseBenchmarks suite to retrieve the corresponding benchmarks.
The percentages accompanying time and memory values in the below table are noise tolerances. The "true"
time/memory value for a given benchmark is expected to fall within this percentage of the reported value.
An empty cell means that the value was zero.

ID	time	GC time	memory	allocations
`["append", "append!!(::SVector, ::SingletonVector)"]`	947.403 μs (5%)		1.53 MiB (1%)	100000
`["append", "append!!(::Vector, ::SingletonVector)"]`	479.401 μs (5%)
`["append", "append!!(Empty(SVector), ::SingletonVector)"]`	3.200 ns (5%)
`["collectors", ":comp => \"filter\"", ":impl => \"base\""]`	43.400 μs (5%)		128.66 KiB (1%)	14
`["collectors", ":comp => \"filter\"", ":impl => \"coll\""]`	50.000 μs (5%)		284.81 KiB (1%)	5012
`["collectors", ":comp => \"filter\"", ":impl => \"nonexpanding\""]`	49.400 μs (5%)		312.75 KiB (1%)	5005
`["collectors", ":comp => \"filter\"", ":impl => \"vec\""]`	44.700 μs (5%)		128.59 KiB (1%)	13
`["collectors", ":comp => \"map\"", ":impl => \"coll\""]`	7.250 μs (5%)		78.20 KiB (1%)	2
`["collectors", ":comp => \"map\"", ":impl => \"man\""]`	7.100 μs (5%)		78.20 KiB (1%)	2
`["collectors", ":comp => \"map\"", ":impl => \"safe_coll\""]`	10.000 μs (5%)		78.20 KiB (1%)	2
`["collectors", ":comp => \"map\"", ":impl => \"vec\""]`	76.100 μs (5%)		256.64 KiB (1%)	14
`["dataframes", "Categorical"]`	766.114 ms (5%)	95.073 ms	992.89 MiB (1%)	6318092
`["dataframes", "Int-Int"]`	1.034 ms (5%)		160.23 KiB (1%)	10251
`["dataframes", "Missing-Int"]`	1.466 ms (5%)		160.23 KiB (1%)	10251
`["dataframes", "Missing-String"]`	1.536 ms (5%)		160.27 KiB (1%)	10252
`["dataframes", "String-String"]`	1.427 ms (5%)		160.27 KiB (1%)	10252

Benchmark Group List

Here's a list of all the benchmark groups executed by this job:

["append"]
["collectors", ":comp => \"filter\""]
["collectors", ":comp => \"map\""]
["dataframes"]

Julia versioninfo

Julia Version 1.4.1
Commit 381693d3df* (2020-04-14 17:20 UTC)
Platform Info:
  OS: Linux (x86_64-pc-linux-gnu)
      Ubuntu 18.04.4 LTS
  uname: Linux 5.3.0-1020-azure #21~18.04.1-Ubuntu SMP Wed Apr 15 09:35:56 UTC 2020 x86_64 x86_64
  CPU: Intel(R) Xeon(R) CPU E5-2673 v4 @ 2.30GHz: 
              speed         user         nice          sys         idle          irq
       #1  2294 MHz      18650 s          0 s       1422 s      14578 s          0 s
       #2  2294 MHz       8276 s          0 s       1344 s      24631 s          0 s
       
  Memory: 6.764888763427734 GB (3594.48046875 MB free)
  Uptime: 358.0 sec
  Load Avg:  1.03271484375  0.75439453125  0.3564453125
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-8.0.1 (ORCJIT, broadwell)

Baseline result

Benchmark Report for /home/runner/work/BangBang.jl/BangBang.jl

Job Properties

Time of benchmark: 23 May 2020 - 23:31
Package commit: 69d6a6
Julia commit: 381693
Julia command flags: None
Environment variables: None

Results

Below is a table of this job's results, obtained by running the benchmarks.
The values listed in the ID column have the structure [parent_group, child_group, ..., key], and can be used to
index into the BaseBenchmarks suite to retrieve the corresponding benchmarks.
The percentages accompanying time and memory values in the below table are noise tolerances. The "true"
time/memory value for a given benchmark is expected to fall within this percentage of the reported value.
An empty cell means that the value was zero.

ID	time	GC time	memory	allocations
`["append", "append!!(::SVector, ::SingletonVector)"]`	903.402 μs (5%)		1.53 MiB (1%)	100000
`["append", "append!!(::Vector, ::SingletonVector)"]`	458.601 μs (5%)
`["append", "append!!(Empty(SVector), ::SingletonVector)"]`	3.200 ns (5%)
`["collectors", ":comp => \"filter\"", ":impl => \"base\""]`	41.500 μs (5%)		128.66 KiB (1%)	14
`["collectors", ":comp => \"filter\"", ":impl => \"coll\""]`	50.200 μs (5%)		284.81 KiB (1%)	5012
`["collectors", ":comp => \"filter\"", ":impl => \"nonexpanding\""]`	51.500 μs (5%)		312.75 KiB (1%)	5005
`["collectors", ":comp => \"filter\"", ":impl => \"vec\""]`	43.600 μs (5%)		128.59 KiB (1%)	13
`["collectors", ":comp => \"map\"", ":impl => \"coll\""]`	8.700 μs (5%)		78.20 KiB (1%)	2
`["collectors", ":comp => \"map\"", ":impl => \"man\""]`	6.700 μs (5%)		78.20 KiB (1%)	2
`["collectors", ":comp => \"map\"", ":impl => \"safe_coll\""]`	10.200 μs (5%)		78.20 KiB (1%)	2
`["collectors", ":comp => \"map\"", ":impl => \"vec\""]`	76.200 μs (5%)		256.64 KiB (1%)	14
`["dataframes", "Categorical"]`	942.276 ms (5%)	107.322 ms	992.89 MiB (1%)	6318092
`["dataframes", "Int-Int"]`	1.056 ms (5%)		160.23 KiB (1%)	10251
`["dataframes", "Missing-Int"]`	1.394 ms (5%)		160.23 KiB (1%)	10251
`["dataframes", "Missing-String"]`	1.483 ms (5%)		160.27 KiB (1%)	10252
`["dataframes", "String-String"]`	1.426 ms (5%)		160.27 KiB (1%)	10252

Benchmark Group List

Here's a list of all the benchmark groups executed by this job:

["append"]
["collectors", ":comp => \"filter\""]
["collectors", ":comp => \"map\""]
["dataframes"]

Julia versioninfo

Julia Version 1.4.1
Commit 381693d3df* (2020-04-14 17:20 UTC)
Platform Info:
  OS: Linux (x86_64-pc-linux-gnu)
      Ubuntu 18.04.4 LTS
  uname: Linux 5.3.0-1020-azure #21~18.04.1-Ubuntu SMP Wed Apr 15 09:35:56 UTC 2020 x86_64 x86_64
  CPU: Intel(R) Xeon(R) CPU E5-2673 v4 @ 2.30GHz: 
              speed         user         nice          sys         idle          irq
       #1  2294 MHz      26462 s          0 s       1547 s      16318 s          0 s
       #2  2294 MHz      10032 s          0 s       1460 s      32458 s          0 s
       
  Memory: 6.764888763427734 GB (3572.8203125 MB free)
  Uptime: 455.0 sec
  Load Avg:  1.02392578125  0.837890625  0.427734375
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-8.0.1 (ORCJIT, broadwell)

Runtime information

Runtime Info
BLAS #threads	2
`BLAS.vendor()`	`openblas64`
`Sys.CPU_THREADS`	2

lscpu output:

Architecture:        x86_64
CPU op-mode(s):      32-bit, 64-bit
Byte Order:          Little Endian
CPU(s):              2
On-line CPU(s) list: 0,1
Thread(s) per core:  1
Core(s) per socket:  2
Socket(s):           1
NUMA node(s):        1
Vendor ID:           GenuineIntel
CPU family:          6
Model:               79
Model name:          Intel(R) Xeon(R) CPU E5-2673 v4 @ 2.30GHz
Stepping:            1
CPU MHz:             2294.685
BogoMIPS:            4589.37
Hypervisor vendor:   Microsoft
Virtualization type: full
L1d cache:           32K
L1i cache:           32K
L2 cache:            256K
L3 cache:            51200K
NUMA node0 CPU(s):   0,1
Flags:               fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ss ht syscall nx pdpe1gb rdtscp lm constant_tsc rep_good nopl xtopology cpuid pni pclmulqdq ssse3 fma cx16 pcid sse4_1 sse4_2 movbe popcnt aes xsave avx f16c rdrand hypervisor lahf_lm abm 3dnowprefetch invpcid_single pti fsgsbase bmi1 hle avx2 smep bmi2 erms invpcid rtm rdseed adx smap xsaveopt md_clear

Cpu Property	Value
Brand	Intel(R) Xeon(R) CPU E5-2673 v4 @ 2.30GHz
Vendor	:Intel
Architecture	:Broadwell
Model	Family: 0x06, Model: 0x4f, Stepping: 0x01, Type: 0x00
Cores	2 physical cores, 2 logical cores (on executing CPU)
	No Hyperthreading detected
Clock Frequencies	Not supported by CPU
Data Cache	Level 1:3 : (32, 256, 51200) kbytes
	64 byte cache line size
Address Size	48 bits virtual, 44 bits physical
SIMD	256 bit = 32 byte max. SIMD vector size
Time Stamp Counter	TSC is accessible via `rdtsc`
	TSC increased at every clock cycle (non-invariant TSC)
Perf. Monitoring	Performance Monitoring Counters (PMC) are not supported
Hypervisor	Yes, Microsoft

Using commit: Fix ambiguity of promote_rule in Julia 1.0 (< 1.3) JuliaFolds/InitialValues.jl@4ecc368

github-actions · 2020-05-24T00:01:34Z

Benchmark result

Judge result

Benchmark Report for /home/runner/work/BangBang.jl/BangBang.jl

Job Properties

Time of benchmarks:
- Target: 23 May 2020 - 23:59
- Baseline: 24 May 2020 - 00:01
Package commits:
- Target: 43b829
- Baseline: 69d6a6
Julia commits:
- Target: 381693
- Baseline: 381693
Julia command flags:
- Target: None
- Baseline: None
Environment variables:
- Target: None
- Baseline: None

Results

A ratio greater than 1.0 denotes a possible regression (marked with ❌), while a ratio less
than 1.0 denotes a possible improvement (marked with ✅). Only significant results - results
that indicate possible regressions or improvements - are shown below (thus, an empty table means that all
benchmark results remained invariant between builds).

ID	time ratio	memory ratio
`["collectors", ":comp => \"map\"", ":impl => \"coll\""]`	1.07 (5%) ❌	1.00 (1%)
`["collectors", ":comp => \"map\"", ":impl => \"man\""]`	1.09 (5%) ❌	1.00 (1%)
`["dataframes", "Categorical"]`	0.85 (5%) ✅	1.00 (1%)
`["dataframes", "Missing-String"]`	1.07 (5%) ❌	1.00 (1%)

Benchmark Group List

Here's a list of all the benchmark groups executed by this job:

["append"]
["collectors", ":comp => \"filter\""]
["collectors", ":comp => \"map\""]
["dataframes"]

Julia versioninfo

Target

Julia Version 1.4.1
Commit 381693d3df* (2020-04-14 17:20 UTC)
Platform Info:
  OS: Linux (x86_64-pc-linux-gnu)
      Ubuntu 18.04.4 LTS
  uname: Linux 5.3.0-1020-azure #21~18.04.1-Ubuntu SMP Wed Apr 15 09:35:56 UTC 2020 x86_64 x86_64
  CPU: Intel(R) Xeon(R) CPU E5-2673 v4 @ 2.30GHz: 
              speed         user         nice          sys         idle          irq
       #1  2294 MHz       6050 s          0 s        948 s      42641 s          0 s
       #2  2294 MHz      18553 s          0 s       1720 s      27299 s          0 s
       
  Memory: 6.764888763427734 GB (3561.69921875 MB free)
  Uptime: 536.0 sec
  Load Avg:  1.0908203125  0.77392578125  0.40185546875
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-8.0.1 (ORCJIT, broadwell)

Baseline

Julia Version 1.4.1
Commit 381693d3df* (2020-04-14 17:20 UTC)
Platform Info:
  OS: Linux (x86_64-pc-linux-gnu)
      Ubuntu 18.04.4 LTS
  uname: Linux 5.3.0-1020-azure #21~18.04.1-Ubuntu SMP Wed Apr 15 09:35:56 UTC 2020 x86_64 x86_64
  CPU: Intel(R) Xeon(R) CPU E5-2673 v4 @ 2.30GHz: 
              speed         user         nice          sys         idle          irq
       #1  2294 MHz       6570 s          0 s       1005 s      50800 s          0 s
       #2  2294 MHz      26624 s          0 s       1889 s      27789 s          0 s
       
  Memory: 6.764888763427734 GB (3539.53125 MB free)
  Uptime: 624.0 sec
  Load Avg:  1.02001953125  0.83349609375  0.45947265625
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-8.0.1 (ORCJIT, broadwell)

Target result

Benchmark Report for /home/runner/work/BangBang.jl/BangBang.jl

Job Properties

Time of benchmark: 23 May 2020 - 23:59
Package commit: 43b829
Julia commit: 381693
Julia command flags: None
Environment variables: None

Results

Below is a table of this job's results, obtained by running the benchmarks.
The values listed in the ID column have the structure [parent_group, child_group, ..., key], and can be used to
index into the BaseBenchmarks suite to retrieve the corresponding benchmarks.
The percentages accompanying time and memory values in the below table are noise tolerances. The "true"
time/memory value for a given benchmark is expected to fall within this percentage of the reported value.
An empty cell means that the value was zero.

ID	time	GC time	memory	allocations
`["append", "append!!(::SVector, ::SingletonVector)"]`	799.000 μs (5%)		1.53 MiB (1%)	100000
`["append", "append!!(::Vector, ::SingletonVector)"]`	407.800 μs (5%)
`["append", "append!!(Empty(SVector), ::SingletonVector)"]`	2.800 ns (5%)
`["collectors", ":comp => \"filter\"", ":impl => \"base\""]`	30.600 μs (5%)		128.66 KiB (1%)	14
`["collectors", ":comp => \"filter\"", ":impl => \"coll\""]`	37.300 μs (5%)		284.81 KiB (1%)	5012
`["collectors", ":comp => \"filter\"", ":impl => \"nonexpanding\""]`	31.800 μs (5%)		312.75 KiB (1%)	5005
`["collectors", ":comp => \"filter\"", ":impl => \"vec\""]`	32.600 μs (5%)		128.59 KiB (1%)	13
`["collectors", ":comp => \"map\"", ":impl => \"coll\""]`	4.300 μs (5%)		78.20 KiB (1%)	2
`["collectors", ":comp => \"map\"", ":impl => \"man\""]`	4.250 μs (5%)		78.20 KiB (1%)	2
`["collectors", ":comp => \"map\"", ":impl => \"safe_coll\""]`	8.767 μs (5%)		78.20 KiB (1%)	2
`["collectors", ":comp => \"map\"", ":impl => \"vec\""]`	57.200 μs (5%)		256.64 KiB (1%)	14
`["dataframes", "Categorical"]`	623.762 ms (5%)	73.360 ms	992.89 MiB (1%)	6318092
`["dataframes", "Int-Int"]`	917.801 μs (5%)		160.23 KiB (1%)	10251
`["dataframes", "Missing-Int"]`	1.309 ms (5%)		160.23 KiB (1%)	10251
`["dataframes", "Missing-String"]`	1.363 ms (5%)		160.27 KiB (1%)	10252
`["dataframes", "String-String"]`	1.267 ms (5%)		160.27 KiB (1%)	10252

Benchmark Group List

Here's a list of all the benchmark groups executed by this job:

["append"]
["collectors", ":comp => \"filter\""]
["collectors", ":comp => \"map\""]
["dataframes"]

Julia versioninfo

Julia Version 1.4.1
Commit 381693d3df* (2020-04-14 17:20 UTC)
Platform Info:
  OS: Linux (x86_64-pc-linux-gnu)
      Ubuntu 18.04.4 LTS
  uname: Linux 5.3.0-1020-azure #21~18.04.1-Ubuntu SMP Wed Apr 15 09:35:56 UTC 2020 x86_64 x86_64
  CPU: Intel(R) Xeon(R) CPU E5-2673 v4 @ 2.30GHz: 
              speed         user         nice          sys         idle          irq
       #1  2294 MHz       6050 s          0 s        948 s      42641 s          0 s
       #2  2294 MHz      18553 s          0 s       1720 s      27299 s          0 s
       
  Memory: 6.764888763427734 GB (3561.69921875 MB free)
  Uptime: 536.0 sec
  Load Avg:  1.0908203125  0.77392578125  0.40185546875
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-8.0.1 (ORCJIT, broadwell)

Baseline result

Benchmark Report for /home/runner/work/BangBang.jl/BangBang.jl

Job Properties

Time of benchmark: 24 May 2020 - 0:1
Package commit: 69d6a6
Julia commit: 381693
Julia command flags: None
Environment variables: None

Results

Below is a table of this job's results, obtained by running the benchmarks.
The values listed in the ID column have the structure [parent_group, child_group, ..., key], and can be used to
index into the BaseBenchmarks suite to retrieve the corresponding benchmarks.
The percentages accompanying time and memory values in the below table are noise tolerances. The "true"
time/memory value for a given benchmark is expected to fall within this percentage of the reported value.
An empty cell means that the value was zero.

ID	time	GC time	memory	allocations
`["append", "append!!(::SVector, ::SingletonVector)"]`	798.200 μs (5%)		1.53 MiB (1%)	100000
`["append", "append!!(::Vector, ::SingletonVector)"]`	407.599 μs (5%)
`["append", "append!!(Empty(SVector), ::SingletonVector)"]`	2.799 ns (5%)
`["collectors", ":comp => \"filter\"", ":impl => \"base\""]`	30.600 μs (5%)		128.66 KiB (1%)	14
`["collectors", ":comp => \"filter\"", ":impl => \"coll\""]`	37.600 μs (5%)		284.81 KiB (1%)	5012
`["collectors", ":comp => \"filter\"", ":impl => \"nonexpanding\""]`	32.600 μs (5%)		312.75 KiB (1%)	5005
`["collectors", ":comp => \"filter\"", ":impl => \"vec\""]`	32.200 μs (5%)		128.59 KiB (1%)	13
`["collectors", ":comp => \"map\"", ":impl => \"coll\""]`	4.000 μs (5%)		78.20 KiB (1%)	2
`["collectors", ":comp => \"map\"", ":impl => \"man\""]`	3.900 μs (5%)		78.20 KiB (1%)	2
`["collectors", ":comp => \"map\"", ":impl => \"safe_coll\""]`	8.800 μs (5%)		78.20 KiB (1%)	2
`["collectors", ":comp => \"map\"", ":impl => \"vec\""]`	56.800 μs (5%)		256.64 KiB (1%)	14
`["dataframes", "Categorical"]`	736.612 ms (5%)	83.081 ms	992.89 MiB (1%)	6318092
`["dataframes", "Int-Int"]`	937.500 μs (5%)		160.23 KiB (1%)	10251
`["dataframes", "Missing-Int"]`	1.248 ms (5%)		160.23 KiB (1%)	10251
`["dataframes", "Missing-String"]`	1.279 ms (5%)		160.27 KiB (1%)	10252
`["dataframes", "String-String"]`	1.270 ms (5%)		160.27 KiB (1%)	10252

Benchmark Group List

Here's a list of all the benchmark groups executed by this job:

["append"]
["collectors", ":comp => \"filter\""]
["collectors", ":comp => \"map\""]
["dataframes"]

Julia versioninfo

Julia Version 1.4.1
Commit 381693d3df* (2020-04-14 17:20 UTC)
Platform Info:
  OS: Linux (x86_64-pc-linux-gnu)
      Ubuntu 18.04.4 LTS
  uname: Linux 5.3.0-1020-azure #21~18.04.1-Ubuntu SMP Wed Apr 15 09:35:56 UTC 2020 x86_64 x86_64
  CPU: Intel(R) Xeon(R) CPU E5-2673 v4 @ 2.30GHz: 
              speed         user         nice          sys         idle          irq
       #1  2294 MHz       6570 s          0 s       1005 s      50800 s          0 s
       #2  2294 MHz      26624 s          0 s       1889 s      27789 s          0 s
       
  Memory: 6.764888763427734 GB (3539.53125 MB free)
  Uptime: 624.0 sec
  Load Avg:  1.02001953125  0.83349609375  0.45947265625
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-8.0.1 (ORCJIT, broadwell)

Runtime information

Runtime Info
BLAS #threads	2
`BLAS.vendor()`	`openblas64`
`Sys.CPU_THREADS`	2

lscpu output:

Architecture:        x86_64
CPU op-mode(s):      32-bit, 64-bit
Byte Order:          Little Endian
CPU(s):              2
On-line CPU(s) list: 0,1
Thread(s) per core:  1
Core(s) per socket:  2
Socket(s):           1
NUMA node(s):        1
Vendor ID:           GenuineIntel
CPU family:          6
Model:               79
Model name:          Intel(R) Xeon(R) CPU E5-2673 v4 @ 2.30GHz
Stepping:            1
CPU MHz:             2294.688
BogoMIPS:            4589.37
Hypervisor vendor:   Microsoft
Virtualization type: full
L1d cache:           32K
L1i cache:           32K
L2 cache:            256K
L3 cache:            51200K
NUMA node0 CPU(s):   0,1
Flags:               fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ss ht syscall nx pdpe1gb rdtscp lm constant_tsc rep_good nopl xtopology cpuid pni pclmulqdq ssse3 fma cx16 pcid sse4_1 sse4_2 movbe popcnt aes xsave avx f16c rdrand hypervisor lahf_lm abm 3dnowprefetch invpcid_single pti fsgsbase bmi1 hle avx2 smep bmi2 erms invpcid rtm rdseed adx smap xsaveopt md_clear

Cpu Property	Value
Brand	Intel(R) Xeon(R) CPU E5-2673 v4 @ 2.30GHz
Vendor	:Intel
Architecture	:Broadwell
Model	Family: 0x06, Model: 0x4f, Stepping: 0x01, Type: 0x00
Cores	2 physical cores, 2 logical cores (on executing CPU)
	No Hyperthreading detected
Clock Frequencies	Not supported by CPU
Data Cache	Level 1:3 : (32, 256, 51200) kbytes
	64 byte cache line size
Address Size	48 bits virtual, 44 bits physical
SIMD	256 bit = 32 byte max. SIMD vector size
Time Stamp Counter	TSC is accessible via `rdtsc`
	TSC increased at every clock cycle (non-invariant TSC)
Perf. Monitoring	Performance Monitoring Counters (PMC) are not supported
Hypervisor	Yes, Microsoft

github-actions · 2020-05-24T00:55:35Z

Benchmark result

Judge result

Benchmark Report for /home/runner/work/BangBang.jl/BangBang.jl

Job Properties

Time of benchmarks:
- Target: 24 May 2020 - 00:53
- Baseline: 24 May 2020 - 00:55
Package commits:
- Target: 5e01ac
- Baseline: 69d6a6
Julia commits:
- Target: 381693
- Baseline: 381693
Julia command flags:
- Target: None
- Baseline: None
Environment variables:
- Target: None
- Baseline: None

Results

A ratio greater than 1.0 denotes a possible regression (marked with ❌), while a ratio less
than 1.0 denotes a possible improvement (marked with ✅). Only significant results - results
that indicate possible regressions or improvements - are shown below (thus, an empty table means that all
benchmark results remained invariant between builds).

ID	time ratio	memory ratio
`["collectors", ":comp => \"map\"", ":impl => \"coll\""]`	1.29 (5%) ❌	1.00 (1%)
`["dataframes", "Categorical"]`	0.90 (5%) ✅	1.00 (1%)
`["dataframes", "Int-Int"]`	1.40 (5%) ❌	1.00 (1%)
`["dataframes", "Missing-Int"]`	1.50 (5%) ❌	1.00 (1%)

Benchmark Group List

Here's a list of all the benchmark groups executed by this job:

["append"]
["collectors", ":comp => \"filter\""]
["collectors", ":comp => \"map\""]
["dataframes"]

Julia versioninfo

Target

Julia Version 1.4.1
Commit 381693d3df* (2020-04-14 17:20 UTC)
Platform Info:
  OS: Linux (x86_64-pc-linux-gnu)
      Ubuntu 18.04.4 LTS
  uname: Linux 5.3.0-1020-azure #21~18.04.1-Ubuntu SMP Wed Apr 15 09:35:56 UTC 2020 x86_64 x86_64
  CPU: Intel(R) Xeon(R) Platinum 8171M CPU @ 2.60GHz: 
              speed         user         nice          sys         idle          irq
       #1  2095 MHz       5648 s          0 s       1367 s      82188 s          0 s
       #2  2095 MHz      19339 s          0 s       1946 s      66229 s          0 s
       
  Memory: 6.764888763427734 GB (3525.92578125 MB free)
  Uptime: 956.0 sec
  Load Avg:  1.1494140625  0.904296875  0.46728515625
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-8.0.1 (ORCJIT, skylake)

Baseline

Julia Version 1.4.1
Commit 381693d3df* (2020-04-14 17:20 UTC)
Platform Info:
  OS: Linux (x86_64-pc-linux-gnu)
      Ubuntu 18.04.4 LTS
  uname: Linux 5.3.0-1020-azure #21~18.04.1-Ubuntu SMP Wed Apr 15 09:35:56 UTC 2020 x86_64 x86_64
  CPU: Intel(R) Xeon(R) Platinum 8171M CPU @ 2.60GHz: 
              speed         user         nice          sys         idle          irq
       #1  2095 MHz       7983 s          0 s       1440 s      88639 s          0 s
       #2  2095 MHz      25721 s          0 s       2128 s      68521 s          0 s
       
  Memory: 6.764888763427734 GB (3552.99609375 MB free)
  Uptime: 1045.0 sec
  Load Avg:  1.0751953125  0.94580078125  0.5224609375
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-8.0.1 (ORCJIT, skylake)

Target result

Benchmark Report for /home/runner/work/BangBang.jl/BangBang.jl

Job Properties

Time of benchmark: 24 May 2020 - 0:53
Package commit: 5e01ac
Julia commit: 381693
Julia command flags: None
Environment variables: None

Results

Below is a table of this job's results, obtained by running the benchmarks.
The values listed in the ID column have the structure [parent_group, child_group, ..., key], and can be used to
index into the BaseBenchmarks suite to retrieve the corresponding benchmarks.
The percentages accompanying time and memory values in the below table are noise tolerances. The "true"
time/memory value for a given benchmark is expected to fall within this percentage of the reported value.
An empty cell means that the value was zero.

ID	time	GC time	memory	allocations
`["append", "append!!(::SVector, ::SingletonVector)"]`	782.905 μs (5%)		1.53 MiB (1%)	100000
`["append", "append!!(::Vector, ::SingletonVector)"]`	400.302 μs (5%)
`["append", "append!!(Empty(SVector), ::SingletonVector)"]`	2.800 ns (5%)
`["collectors", ":comp => \"filter\"", ":impl => \"base\""]`	31.800 μs (5%)		128.66 KiB (1%)	14
`["collectors", ":comp => \"filter\"", ":impl => \"coll\""]`	33.300 μs (5%)		284.81 KiB (1%)	5012
`["collectors", ":comp => \"filter\"", ":impl => \"nonexpanding\""]`	30.900 μs (5%)		312.75 KiB (1%)	5005
`["collectors", ":comp => \"filter\"", ":impl => \"vec\""]`	32.100 μs (5%)		128.59 KiB (1%)	13
`["collectors", ":comp => \"map\"", ":impl => \"coll\""]`	5.550 μs (5%)		78.20 KiB (1%)	2
`["collectors", ":comp => \"map\"", ":impl => \"man\""]`	5.160 μs (5%)		78.20 KiB (1%)	2
`["collectors", ":comp => \"map\"", ":impl => \"safe_coll\""]`	9.300 μs (5%)		78.20 KiB (1%)	2
`["collectors", ":comp => \"map\"", ":impl => \"vec\""]`	58.400 μs (5%)		256.64 KiB (1%)	14
`["dataframes", "Categorical"]`	626.028 ms (5%)	68.545 ms	992.89 MiB (1%)	6318092
`["dataframes", "Int-Int"]`	1.196 ms (5%)		160.23 KiB (1%)	10251
`["dataframes", "Missing-Int"]`	1.741 ms (5%)		160.23 KiB (1%)	10251
`["dataframes", "Missing-String"]`	1.219 ms (5%)		160.27 KiB (1%)	10252
`["dataframes", "String-String"]`	1.147 ms (5%)		160.27 KiB (1%)	10252

Benchmark Group List

Here's a list of all the benchmark groups executed by this job:

["append"]
["collectors", ":comp => \"filter\""]
["collectors", ":comp => \"map\""]
["dataframes"]

Julia versioninfo

Julia Version 1.4.1
Commit 381693d3df* (2020-04-14 17:20 UTC)
Platform Info:
  OS: Linux (x86_64-pc-linux-gnu)
      Ubuntu 18.04.4 LTS
  uname: Linux 5.3.0-1020-azure #21~18.04.1-Ubuntu SMP Wed Apr 15 09:35:56 UTC 2020 x86_64 x86_64
  CPU: Intel(R) Xeon(R) Platinum 8171M CPU @ 2.60GHz: 
              speed         user         nice          sys         idle          irq
       #1  2095 MHz       5648 s          0 s       1367 s      82188 s          0 s
       #2  2095 MHz      19339 s          0 s       1946 s      66229 s          0 s
       
  Memory: 6.764888763427734 GB (3525.92578125 MB free)
  Uptime: 956.0 sec
  Load Avg:  1.1494140625  0.904296875  0.46728515625
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-8.0.1 (ORCJIT, skylake)

Baseline result

Benchmark Report for /home/runner/work/BangBang.jl/BangBang.jl

Job Properties

Time of benchmark: 24 May 2020 - 0:55
Package commit: 69d6a6
Julia commit: 381693
Julia command flags: None
Environment variables: None

Results

Below is a table of this job's results, obtained by running the benchmarks.
The values listed in the ID column have the structure [parent_group, child_group, ..., key], and can be used to
index into the BaseBenchmarks suite to retrieve the corresponding benchmarks.
The percentages accompanying time and memory values in the below table are noise tolerances. The "true"
time/memory value for a given benchmark is expected to fall within this percentage of the reported value.
An empty cell means that the value was zero.

ID	time	GC time	memory	allocations
`["append", "append!!(::SVector, ::SingletonVector)"]`	783.503 μs (5%)		1.53 MiB (1%)	100000
`["append", "append!!(::Vector, ::SingletonVector)"]`	403.402 μs (5%)
`["append", "append!!(Empty(SVector), ::SingletonVector)"]`	2.800 ns (5%)
`["collectors", ":comp => \"filter\"", ":impl => \"base\""]`	31.500 μs (5%)		128.66 KiB (1%)	14
`["collectors", ":comp => \"filter\"", ":impl => \"coll\""]`	33.700 μs (5%)		284.81 KiB (1%)	5012
`["collectors", ":comp => \"filter\"", ":impl => \"nonexpanding\""]`	30.300 μs (5%)		312.75 KiB (1%)	5005
`["collectors", ":comp => \"filter\"", ":impl => \"vec\""]`	30.600 μs (5%)		128.59 KiB (1%)	13
`["collectors", ":comp => \"map\"", ":impl => \"coll\""]`	4.300 μs (5%)		78.20 KiB (1%)	2
`["collectors", ":comp => \"map\"", ":impl => \"man\""]`	5.400 μs (5%)		78.20 KiB (1%)	2
`["collectors", ":comp => \"map\"", ":impl => \"safe_coll\""]`	9.300 μs (5%)		78.20 KiB (1%)	2
`["collectors", ":comp => \"map\"", ":impl => \"vec\""]`	57.200 μs (5%)		256.64 KiB (1%)	14
`["dataframes", "Categorical"]`	696.204 ms (5%)	81.796 ms	992.89 MiB (1%)	6318092
`["dataframes", "Int-Int"]`	855.105 μs (5%)		160.23 KiB (1%)	10251
`["dataframes", "Missing-Int"]`	1.162 ms (5%)		160.23 KiB (1%)	10251
`["dataframes", "Missing-String"]`	1.205 ms (5%)		160.27 KiB (1%)	10252
`["dataframes", "String-String"]`	1.129 ms (5%)		160.27 KiB (1%)	10252

Benchmark Group List

Here's a list of all the benchmark groups executed by this job:

["append"]
["collectors", ":comp => \"filter\""]
["collectors", ":comp => \"map\""]
["dataframes"]

Julia versioninfo

Julia Version 1.4.1
Commit 381693d3df* (2020-04-14 17:20 UTC)
Platform Info:
  OS: Linux (x86_64-pc-linux-gnu)
      Ubuntu 18.04.4 LTS
  uname: Linux 5.3.0-1020-azure #21~18.04.1-Ubuntu SMP Wed Apr 15 09:35:56 UTC 2020 x86_64 x86_64
  CPU: Intel(R) Xeon(R) Platinum 8171M CPU @ 2.60GHz: 
              speed         user         nice          sys         idle          irq
       #1  2095 MHz       7983 s          0 s       1440 s      88639 s          0 s
       #2  2095 MHz      25721 s          0 s       2128 s      68521 s          0 s
       
  Memory: 6.764888763427734 GB (3552.99609375 MB free)
  Uptime: 1045.0 sec
  Load Avg:  1.0751953125  0.94580078125  0.5224609375
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-8.0.1 (ORCJIT, skylake)

Runtime information

Runtime Info
BLAS #threads	2
`BLAS.vendor()`	`openblas64`
`Sys.CPU_THREADS`	2

lscpu output:

Architecture:        x86_64
CPU op-mode(s):      32-bit, 64-bit
Byte Order:          Little Endian
CPU(s):              2
On-line CPU(s) list: 0,1
Thread(s) per core:  1
Core(s) per socket:  2
Socket(s):           1
NUMA node(s):        1
Vendor ID:           GenuineIntel
CPU family:          6
Model:               85
Model name:          Intel(R) Xeon(R) Platinum 8171M CPU @ 2.60GHz
Stepping:            4
CPU MHz:             2095.076
BogoMIPS:            4190.15
Hypervisor vendor:   Microsoft
Virtualization type: full
L1d cache:           32K
L1i cache:           32K
L2 cache:            1024K
L3 cache:            36608K
NUMA node0 CPU(s):   0,1
Flags:               fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ss ht syscall nx pdpe1gb rdtscp lm constant_tsc rep_good nopl xtopology cpuid pni pclmulqdq ssse3 fma cx16 pcid sse4_1 sse4_2 movbe popcnt aes xsave avx f16c rdrand hypervisor lahf_lm abm 3dnowprefetch invpcid_single pti fsgsbase bmi1 hle avx2 smep bmi2 erms invpcid rtm mpx avx512f avx512dq rdseed adx smap clflushopt avx512cd avx512bw avx512vl xsaveopt xsavec xsaves

Cpu Property	Value
Brand	Intel(R) Xeon(R) Platinum 8171M CPU @ 2.60GHz
Vendor	:Intel
Architecture	:Skylake
Model	Family: 0x06, Model: 0x55, Stepping: 0x04, Type: 0x00
Cores	2 physical cores, 2 logical cores (on executing CPU)
	No Hyperthreading detected
Clock Frequencies	Not supported by CPU
Data Cache	Level 1:3 : (32, 1024, 36608) kbytes
	64 byte cache line size
Address Size	48 bits virtual, 44 bits physical
SIMD	512 bit = 64 byte max. SIMD vector size
Time Stamp Counter	TSC is accessible via `rdtsc`
	TSC increased at every clock cycle (non-invariant TSC)
Perf. Monitoring	Performance Monitoring Counters (PMC) are not supported
Hypervisor	Yes, Microsoft

This introduces two recent important updates in BangBang: * Custom definition for `append!!(_, Init(append!!))` JuliaFolds/BangBang.jl#148 (requires v0.3.23) * Fix widening path of `materialize!!` JuliaFolds/BangBang.jl#154 (requires v0.3.24)

tkf added 2 commits May 23, 2020 16:21

Update: InitialValues

035ce59

Using commit: Add `INIT` that works with arbitrary operators JuliaFolds/InitialValues.jl@b5b0777

Custom definition for monoid!!(_, Init(monoid!!))

a301a73

tkf force-pushed the bottom-init branch from 772f084 to a301a73 Compare May 23, 2020 23:24

tkf changed the title ~~Defining a custom return type of Init(append!!)~~ Custom definition for monoid!!(_, Init(monoid!!)) May 23, 2020

Update: InitialValues

36383fb

Using commit: Fix ambiguity of promote_rule in Julia 1.0 (< 1.3) JuliaFolds/InitialValues.jl@4ecc368

tkf changed the title ~~Custom definition for monoid!!(_, Init(monoid!!))~~ Custom definition for append!!(_, Init(append!!)) May 23, 2020

tkf added the ready-to-merge:squash label May 24, 2020

Use InitialValues 0.2.5 in test/environments/old

0b7d641

mergify bot approved these changes May 24, 2020

View reviewed changes

mergify bot merged commit 285432d into master May 24, 2020

mergify bot deleted the bottom-init branch May 24, 2020 00:59

tkf mentioned this pull request May 25, 2020

Define Init(mergewith!!(f)), Init(merge!!) and Init(union!!) #151

Merged

tkf mentioned this pull request Jun 1, 2020

Require BangBang 0.3.24 JuliaFolds/Transducers.jl#299

Merged

Custom definition for append!!(_, Init(append!!)) #148

Custom definition for append!!(_, Init(append!!)) #148

Conversation

tkf commented May 23, 2020 • edited Loading

Alternative approach

Commit Message

codecov-commenter commented May 23, 2020 • edited Loading

Codecov Report

github-actions bot commented May 23, 2020

Judge result

Benchmark Report for /home/runner/work/BangBang.jl/BangBang.jl

Job Properties

Results

Benchmark Group List

Julia versioninfo

Target

Baseline

Target result

Benchmark Report for /home/runner/work/BangBang.jl/BangBang.jl

Job Properties

Results

Benchmark Group List

Julia versioninfo

Baseline result

Benchmark Report for /home/runner/work/BangBang.jl/BangBang.jl

Job Properties

Results

Benchmark Group List

Julia versioninfo

Runtime information

github-actions bot commented May 24, 2020

Judge result

Benchmark Report for /home/runner/work/BangBang.jl/BangBang.jl

Job Properties

Results

Benchmark Group List

Julia versioninfo

Target

Baseline

Target result

Benchmark Report for /home/runner/work/BangBang.jl/BangBang.jl

Job Properties

Results

Benchmark Group List

Julia versioninfo

Baseline result

Benchmark Report for /home/runner/work/BangBang.jl/BangBang.jl

Job Properties

Results

Benchmark Group List

Julia versioninfo

Runtime information

github-actions bot commented May 24, 2020

Judge result

Benchmark Report for /home/runner/work/BangBang.jl/BangBang.jl

Job Properties

Results

Benchmark Group List

Julia versioninfo

Target

Baseline

Target result

Benchmark Report for /home/runner/work/BangBang.jl/BangBang.jl

Job Properties

Results

Benchmark Group List

Julia versioninfo

Baseline result

Benchmark Report for /home/runner/work/BangBang.jl/BangBang.jl

Job Properties

Results

Benchmark Group List

Julia versioninfo

Runtime information

Custom definition for `append!!(_, Init(append!!))` #148

Custom definition for `append!!(_, Init(append!!))` #148

tkf commented May 23, 2020 •

edited

Loading

codecov-commenter commented May 23, 2020 •

edited

Loading