Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix single-thread overhead of reduce #309

Merged
merged 1 commit into from
Jun 23, 2020
Merged

Conversation

tkf
Copy link
Member

@tkf tkf commented Jun 23, 2020

close #307

@codecov
Copy link

codecov bot commented Jun 23, 2020

Codecov Report

Merging #309 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #309   +/-   ##
=======================================
  Coverage   89.98%   89.98%           
=======================================
  Files          24       24           
  Lines        1448     1448           
=======================================
  Hits         1303     1303           
  Misses        145      145           
Impacted Files Coverage Δ
src/reduce.jl 81.18% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff8ec32...1445580. Read the comment docs.

@github-actions
Copy link
Contributor

Benchmark result

Judge result

Benchmark Report for /home/runner/work/Transducers.jl/Transducers.jl

Job Properties

  • Time of benchmarks:
    • Target: 23 Jun 2020 - 01:19
    • Baseline: 23 Jun 2020 - 01:24
  • Package commits:
    • Target: 510cf7
    • Baseline: ff8ec3
  • Julia commits:
    • Target: 44fa15
    • Baseline: 44fa15
  • Julia command flags:
    • Target: None
    • Baseline: None
  • Environment variables:
    • Target: OMP_NUM_THREADS => 1 JULIA_NUM_THREADS => 1
    • Baseline: OMP_NUM_THREADS => 1 JULIA_NUM_THREADS => 1

Results

A ratio greater than 1.0 denotes a possible regression (marked with ❌), while a ratio less
than 1.0 denotes a possible improvement (marked with ✅). Only significant results - results
that indicate possible regressions or improvements - are shown below (thus, an empty table means that all
benchmark results remained invariant between builds).

ID time ratio memory ratio
["cat", "base"] 1.15 (5%) ❌ 1.00 (1%)
["cat", "xf"] 1.10 (5%) ❌ 1.00 (1%)
["collect", "filter-missing"] 1.14 (5%) ❌ 1.00 (1%)
["collect", "identity-float"] 1.17 (5%) ❌ 1.00 (1%)
["collect", "identity-union"] 1.05 (5%) ❌ 1.00 (1%)
["dot", "man"] 1.08 (5%) ❌ 1.00 (1%)
["dot", "rf"] 1.07 (5%) ❌ 1.00 (1%)
["dot", "xf"] 1.07 (5%) ❌ 1.00 (1%)
["findall", "xf-array"] 0.99 (5%) 0.97 (1%) ✅
["findall", "xf-iter"] 1.06 (5%) ❌ 1.00 (1%)
["gemm", "mul", "man", "false", "32"] 0.84 (5%) ✅ 1.00 (1%)
["gemm", "mul", "man", "false", "8"] 1.13 (5%) ❌ 1.00 (1%)
["gemm", "mul", "man", "ivdep", "8"] 1.12 (5%) ❌ 1.00 (1%)
["gemm", "mul", "man", "true", "32"] 1.14 (5%) ❌ 1.00 (1%)
["gemm", "mul", "man", "true", "8"] 1.17 (5%) ❌ 1.00 (1%)
["gemm", "mul", "xf", "false", "32"] 0.89 (5%) ✅ 1.00 (1%)
["gemm", "mul", "xf", "false", "8"] 1.14 (5%) ❌ 1.00 (1%)
["gemm", "mul", "xf", "ivdep", "32"] 0.82 (5%) ✅ 1.00 (1%)
["gemm", "mul", "xf", "ivdep", "8"] 1.13 (5%) ❌ 1.00 (1%)
["gemm", "mul", "xf", "true", "32"] 1.09 (5%) ❌ 1.00 (1%)
["gemm", "mul", "xf", "true", "8"] 1.28 (5%) ❌ 1.00 (1%)
["missing_argmax", "man"] 1.14 (5%) ❌ 1.00 (1%)
["missing_argmax", "rf"] 1.17 (5%) ❌ 1.00 (1%)
["missing_argmax", "xf"] 1.14 (5%) ❌ 1.00 (1%)
["missing_dot", "equiv"] 0.93 (5%) ✅ 1.00 (1%)
["missing_dot", "rf_nota"] 1.06 (5%) ❌ 1.00 (1%)
["missing_dot", "xf"] 1.07 (5%) ❌ 1.00 (1%)
["missing_dot", "xf_nota"] 1.08 (5%) ❌ 1.00 (1%)
["overhead", "foldl"] 1.31 (5%) ❌ 1.00 (1%)
["overhead", "reduce_basecase"] 0.05 (5%) ✅ 0.35 (1%) ✅

Benchmark Group List

Here's a list of all the benchmark groups executed by this job:

  • ["cat"]
  • ["collect"]
  • ["dot"]
  • ["filter_map_map!"]
  • ["filter_map_reduce"]
  • ["findall"]
  • ["gemm", "fusedmul", "blas"]
  • ["gemm", "fusedmul", "xf"]
  • ["gemm", "mul", "linalg"]
  • ["gemm", "mul", "man", "false"]
  • ["gemm", "mul", "man", "ivdep"]
  • ["gemm", "mul", "man", "true"]
  • ["gemm", "mul", "xf", "false"]
  • ["gemm", "mul", "xf", "ivdep"]
  • ["gemm", "mul", "xf", "true"]
  • ["groupby", "sum"]
  • ["missing_argmax"]
  • ["missing_dot"]
  • ["overhead"]
  • ["partition_by"]

Julia versioninfo

Target

Julia Version 1.4.2
Commit 44fa15b150* (2020-05-23 18:35 UTC)
Platform Info:
  OS: Linux (x86_64-pc-linux-gnu)
      Ubuntu 18.04.4 LTS
  uname: Linux 5.3.0-1028-azure #29~18.04.1-Ubuntu SMP Fri Jun 5 14:32:34 UTC 2020 x86_64 x86_64
  CPU: Intel(R) Xeon(R) CPU E5-2673 v3 @ 2.40GHz: 
              speed         user         nice          sys         idle          irq
       #1  2397 MHz      23261 s          0 s       1408 s      40965 s          0 s
       #2  2397 MHz      38062 s          0 s       1429 s      26094 s          0 s
       
  Memory: 6.764884948730469 GB (3374.3828125 MB free)
  Uptime: 671.0 sec
  Load Avg:  1.16455078125  1.02587890625  0.6279296875
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-8.0.1 (ORCJIT, haswell)

Baseline

Julia Version 1.4.2
Commit 44fa15b150* (2020-05-23 18:35 UTC)
Platform Info:
  OS: Linux (x86_64-pc-linux-gnu)
      Ubuntu 18.04.4 LTS
  uname: Linux 5.3.0-1028-azure #29~18.04.1-Ubuntu SMP Fri Jun 5 14:32:34 UTC 2020 x86_64 x86_64
  CPU: Intel(R) Xeon(R) CPU E5-2673 v3 @ 2.40GHz: 
              speed         user         nice          sys         idle          irq
       #1  2397 MHz      37361 s          0 s       1592 s      52933 s          0 s
       #2  2397 MHz      50248 s          0 s       1524 s      40097 s          0 s
       
  Memory: 6.764884948730469 GB (3338.015625 MB free)
  Uptime: 935.0 sec
  Load Avg:  1.0107421875  1.0234375  0.73876953125
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-8.0.1 (ORCJIT, haswell)

Target result

Benchmark Report for /home/runner/work/Transducers.jl/Transducers.jl

Job Properties

  • Time of benchmark: 23 Jun 2020 - 1:19
  • Package commit: 510cf7
  • Julia commit: 44fa15
  • Julia command flags: None
  • Environment variables: OMP_NUM_THREADS => 1 JULIA_NUM_THREADS => 1

Results

Below is a table of this job's results, obtained by running the benchmarks.
The values listed in the ID column have the structure [parent_group, child_group, ..., key], and can be used to
index into the BaseBenchmarks suite to retrieve the corresponding benchmarks.
The percentages accompanying time and memory values in the below table are noise tolerances. The "true"
time/memory value for a given benchmark is expected to fall within this percentage of the reported value.
An empty cell means that the value was zero.

ID time GC time memory allocations
["cat", "base"] 2.078 μs (5%)
["cat", "xf"] 2.010 μs (5%) 80 bytes (1%) 3
["collect", "filter-missing"] 124.904 μs (5%) 345.36 KiB (1%) 10018
["collect", "identity-float"] 106.004 μs (5%) 569.20 KiB (1%) 10018
["collect", "identity-union"] 342.511 μs (5%) 705.27 KiB (1%) 16674
["dot", "blas"] 2.200 μs (5%)
["dot", "man"] 2.311 μs (5%)
["dot", "rf"] 2.722 μs (5%)
["dot", "xf"] 2.722 μs (5%)
["filter_map_map!", "man"] 62.201 μs (5%)
["filter_map_map!", "xf"] 622.411 μs (5%) 304 bytes (1%) 17
["filter_map_reduce", "man"] 226.106 μs (5%)
["filter_map_reduce", "xf"] 226.107 μs (5%)
["findall", "base"] 986.530 μs (5%) 2.00 MiB (1%) 21
["findall", "xf-array"] 857.227 μs (5%) 2.96 MiB (1%) 96854
["findall", "xf-iter"] 3.997 ms (5%) 9.63 MiB (1%) 299935
["gemm", "fusedmul", "blas", "16"] 4.660 ms (5%)
["gemm", "fusedmul", "blas", "2"] 3.454 ms (5%)
["gemm", "fusedmul", "blas", "32"] 6.182 ms (5%)
["gemm", "fusedmul", "blas", "8"] 3.583 ms (5%)
["gemm", "fusedmul", "xf", "16"] 5.319 ms (5%) 160 bytes (1%) 6
["gemm", "fusedmul", "xf", "2"] 633.612 μs (5%) 160 bytes (1%) 6
["gemm", "fusedmul", "xf", "32"] 10.643 ms (5%) 160 bytes (1%) 6
["gemm", "fusedmul", "xf", "8"] 2.627 ms (5%) 160 bytes (1%) 6
["gemm", "mul", "linalg", "256"] 1.004 ms (5%)
["gemm", "mul", "linalg", "32"] 3.563 μs (5%)
["gemm", "mul", "linalg", "8"] 298.664 ns (5%)
["gemm", "mul", "man", "false", "256"] 4.252 ms (5%)
["gemm", "mul", "man", "false", "32"] 6.600 μs (5%)
["gemm", "mul", "man", "false", "8"] 451.782 ns (5%)
["gemm", "mul", "man", "ivdep", "256"] 4.209 ms (5%)
["gemm", "mul", "man", "ivdep", "32"] 5.820 μs (5%)
["gemm", "mul", "man", "ivdep", "8"] 446.975 ns (5%)
["gemm", "mul", "man", "true", "256"] 4.335 ms (5%)
["gemm", "mul", "man", "true", "32"] 7.320 μs (5%)
["gemm", "mul", "man", "true", "8"] 469.903 ns (5%)
["gemm", "mul", "xf", "false", "256"] 4.335 ms (5%) 48 bytes (1%) 2
["gemm", "mul", "xf", "false", "32"] 7.220 μs (5%) 48 bytes (1%) 2
["gemm", "mul", "xf", "false", "8"] 454.325 ns (5%) 48 bytes (1%) 2
["gemm", "mul", "xf", "ivdep", "256"] 4.198 ms (5%) 48 bytes (1%) 2
["gemm", "mul", "xf", "ivdep", "32"] 5.417 μs (5%) 48 bytes (1%) 2
["gemm", "mul", "xf", "ivdep", "8"] 453.310 ns (5%) 48 bytes (1%) 2
["gemm", "mul", "xf", "true", "256"] 4.322 ms (5%) 48 bytes (1%) 2
["gemm", "mul", "xf", "true", "32"] 7.220 μs (5%) 48 bytes (1%) 2
["gemm", "mul", "xf", "true", "8"] 511.178 ns (5%) 48 bytes (1%) 2
["groupby", "sum", "sac"] 257.404 μs (5%) 313.14 KiB (1%) 10007
["groupby", "sum", "xf-with-init"] 200.803 μs (5%) 157.44 KiB (1%) 10008
["groupby", "sum", "xf-without-init"] 196.604 μs (5%) 157.44 KiB (1%) 10008
["missing_argmax", "man"] 1.410 μs (5%) 32 bytes (1%) 1
["missing_argmax", "rf"] 2.889 μs (5%) 32 bytes (1%) 1
["missing_argmax", "xf"] 2.922 μs (5%) 32 bytes (1%) 1
["missing_dot", "equiv"] 1.250 μs (5%) 16 bytes (1%) 1
["missing_dot", "man"] 1.170 μs (5%) 16 bytes (1%) 1
["missing_dot", "naive"] 4.714 μs (5%) 16 bytes (1%) 1
["missing_dot", "rf"] 1.230 μs (5%) 16 bytes (1%) 1
["missing_dot", "rf_nota"] 1.330 μs (5%) 16 bytes (1%) 1
["missing_dot", "xf"] 219.506 μs (5%) 72.05 KiB (1%) 3737
["missing_dot", "xf_nota"] 218.606 μs (5%) 72.13 KiB (1%) 3741
["overhead", "foldl"] 6.300 ns (5%)
["overhead", "reduce_basecase"] 190.636 ns (5%) 416 bytes (1%) 7
["partition_by", "man"] 2.086 ms (5%) 352 bytes (1%) 4
["partition_by", "xf"] 3.216 ms (5%) 6.10 MiB (1%) 200007

Benchmark Group List

Here's a list of all the benchmark groups executed by this job:

  • ["cat"]
  • ["collect"]
  • ["dot"]
  • ["filter_map_map!"]
  • ["filter_map_reduce"]
  • ["findall"]
  • ["gemm", "fusedmul", "blas"]
  • ["gemm", "fusedmul", "xf"]
  • ["gemm", "mul", "linalg"]
  • ["gemm", "mul", "man", "false"]
  • ["gemm", "mul", "man", "ivdep"]
  • ["gemm", "mul", "man", "true"]
  • ["gemm", "mul", "xf", "false"]
  • ["gemm", "mul", "xf", "ivdep"]
  • ["gemm", "mul", "xf", "true"]
  • ["groupby", "sum"]
  • ["missing_argmax"]
  • ["missing_dot"]
  • ["overhead"]
  • ["partition_by"]

Julia versioninfo

Julia Version 1.4.2
Commit 44fa15b150* (2020-05-23 18:35 UTC)
Platform Info:
  OS: Linux (x86_64-pc-linux-gnu)
      Ubuntu 18.04.4 LTS
  uname: Linux 5.3.0-1028-azure #29~18.04.1-Ubuntu SMP Fri Jun 5 14:32:34 UTC 2020 x86_64 x86_64
  CPU: Intel(R) Xeon(R) CPU E5-2673 v3 @ 2.40GHz: 
              speed         user         nice          sys         idle          irq
       #1  2397 MHz      23261 s          0 s       1408 s      40965 s          0 s
       #2  2397 MHz      38062 s          0 s       1429 s      26094 s          0 s
       
  Memory: 6.764884948730469 GB (3374.3828125 MB free)
  Uptime: 671.0 sec
  Load Avg:  1.16455078125  1.02587890625  0.6279296875
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-8.0.1 (ORCJIT, haswell)

Baseline result

Benchmark Report for /home/runner/work/Transducers.jl/Transducers.jl

Job Properties

  • Time of benchmark: 23 Jun 2020 - 1:24
  • Package commit: ff8ec3
  • Julia commit: 44fa15
  • Julia command flags: None
  • Environment variables: OMP_NUM_THREADS => 1 JULIA_NUM_THREADS => 1

Results

Below is a table of this job's results, obtained by running the benchmarks.
The values listed in the ID column have the structure [parent_group, child_group, ..., key], and can be used to
index into the BaseBenchmarks suite to retrieve the corresponding benchmarks.
The percentages accompanying time and memory values in the below table are noise tolerances. The "true"
time/memory value for a given benchmark is expected to fall within this percentage of the reported value.
An empty cell means that the value was zero.

ID time GC time memory allocations
["cat", "base"] 1.811 μs (5%)
["cat", "xf"] 1.830 μs (5%) 80 bytes (1%) 3
["collect", "filter-missing"] 109.302 μs (5%) 345.36 KiB (1%) 10018
["collect", "identity-float"] 90.501 μs (5%) 569.20 KiB (1%) 10018
["collect", "identity-union"] 325.605 μs (5%) 705.34 KiB (1%) 16680
["dot", "blas"] 2.167 μs (5%)
["dot", "man"] 2.145 μs (5%)
["dot", "rf"] 2.533 μs (5%)
["dot", "xf"] 2.533 μs (5%)
["filter_map_map!", "man"] 62.402 μs (5%)
["filter_map_map!", "xf"] 620.407 μs (5%) 304 bytes (1%) 17
["filter_map_reduce", "man"] 226.103 μs (5%)
["filter_map_reduce", "xf"] 226.103 μs (5%)
["findall", "base"] 962.813 μs (5%) 2.00 MiB (1%) 21
["findall", "xf-array"] 863.412 μs (5%) 3.05 MiB (1%) 99838
["findall", "xf-iter"] 3.782 ms (5%) 9.63 MiB (1%) 299927
["gemm", "fusedmul", "blas", "16"] 4.650 ms (5%)
["gemm", "fusedmul", "blas", "2"] 3.433 ms (5%)
["gemm", "fusedmul", "blas", "32"] 6.179 ms (5%)
["gemm", "fusedmul", "blas", "8"] 3.567 ms (5%)
["gemm", "fusedmul", "xf", "16"] 5.316 ms (5%) 160 bytes (1%) 6
["gemm", "fusedmul", "xf", "2"] 631.508 μs (5%) 160 bytes (1%) 6
["gemm", "fusedmul", "xf", "32"] 10.680 ms (5%) 160 bytes (1%) 6
["gemm", "fusedmul", "xf", "8"] 2.629 ms (5%) 160 bytes (1%) 6
["gemm", "mul", "linalg", "256"] 962.312 μs (5%)
["gemm", "mul", "linalg", "32"] 3.400 μs (5%)
["gemm", "mul", "linalg", "8"] 300.000 ns (5%)
["gemm", "mul", "man", "false", "256"] 4.272 ms (5%)
["gemm", "mul", "man", "false", "32"] 7.900 μs (5%)
["gemm", "mul", "man", "false", "8"] 400.000 ns (5%)
["gemm", "mul", "man", "ivdep", "256"] 4.237 ms (5%)
["gemm", "mul", "man", "ivdep", "32"] 5.900 μs (5%)
["gemm", "mul", "man", "ivdep", "8"] 400.000 ns (5%)
["gemm", "mul", "man", "true", "256"] 4.257 ms (5%)
["gemm", "mul", "man", "true", "32"] 6.400 μs (5%)
["gemm", "mul", "man", "true", "8"] 400.000 ns (5%)
["gemm", "mul", "xf", "false", "256"] 4.270 ms (5%) 48 bytes (1%) 2
["gemm", "mul", "xf", "false", "32"] 8.100 μs (5%) 48 bytes (1%) 2
["gemm", "mul", "xf", "false", "8"] 400.000 ns (5%) 48 bytes (1%) 2
["gemm", "mul", "xf", "ivdep", "256"] 4.231 ms (5%) 48 bytes (1%) 2
["gemm", "mul", "xf", "ivdep", "32"] 6.600 μs (5%) 48 bytes (1%) 2
["gemm", "mul", "xf", "ivdep", "8"] 400.000 ns (5%) 48 bytes (1%) 2
["gemm", "mul", "xf", "true", "256"] 4.285 ms (5%) 48 bytes (1%) 2
["gemm", "mul", "xf", "true", "32"] 6.600 μs (5%) 48 bytes (1%) 2
["gemm", "mul", "xf", "true", "8"] 400.000 ns (5%) 48 bytes (1%) 2
["groupby", "sum", "sac"] 259.811 μs (5%) 313.14 KiB (1%) 10007
["groupby", "sum", "xf-with-init"] 201.509 μs (5%) 157.44 KiB (1%) 10008
["groupby", "sum", "xf-without-init"] 195.709 μs (5%) 157.44 KiB (1%) 10008
["missing_argmax", "man"] 1.240 μs (5%) 32 bytes (1%) 1
["missing_argmax", "rf"] 2.467 μs (5%) 32 bytes (1%) 1
["missing_argmax", "xf"] 2.567 μs (5%) 32 bytes (1%) 1
["missing_dot", "equiv"] 1.340 μs (5%) 16 bytes (1%) 1
["missing_dot", "man"] 1.230 μs (5%) 16 bytes (1%) 1
["missing_dot", "naive"] 4.729 μs (5%) 16 bytes (1%) 1
["missing_dot", "rf"] 1.180 μs (5%) 16 bytes (1%) 1
["missing_dot", "rf_nota"] 1.260 μs (5%) 16 bytes (1%) 1
["missing_dot", "xf"] 204.903 μs (5%) 72.27 KiB (1%) 3745
["missing_dot", "xf_nota"] 203.203 μs (5%) 72.02 KiB (1%) 3737
["overhead", "foldl"] 4.800 ns (5%)
["overhead", "reduce_basecase"] 3.939 μs (5%) 1.17 KiB (1%) 21
["partition_by", "man"] 2.053 ms (5%) 352 bytes (1%) 4
["partition_by", "xf"] 3.190 ms (5%) 6.10 MiB (1%) 200007

Benchmark Group List

Here's a list of all the benchmark groups executed by this job:

  • ["cat"]
  • ["collect"]
  • ["dot"]
  • ["filter_map_map!"]
  • ["filter_map_reduce"]
  • ["findall"]
  • ["gemm", "fusedmul", "blas"]
  • ["gemm", "fusedmul", "xf"]
  • ["gemm", "mul", "linalg"]
  • ["gemm", "mul", "man", "false"]
  • ["gemm", "mul", "man", "ivdep"]
  • ["gemm", "mul", "man", "true"]
  • ["gemm", "mul", "xf", "false"]
  • ["gemm", "mul", "xf", "ivdep"]
  • ["gemm", "mul", "xf", "true"]
  • ["groupby", "sum"]
  • ["missing_argmax"]
  • ["missing_dot"]
  • ["overhead"]
  • ["partition_by"]

Julia versioninfo

Julia Version 1.4.2
Commit 44fa15b150* (2020-05-23 18:35 UTC)
Platform Info:
  OS: Linux (x86_64-pc-linux-gnu)
      Ubuntu 18.04.4 LTS
  uname: Linux 5.3.0-1028-azure #29~18.04.1-Ubuntu SMP Fri Jun 5 14:32:34 UTC 2020 x86_64 x86_64
  CPU: Intel(R) Xeon(R) CPU E5-2673 v3 @ 2.40GHz: 
              speed         user         nice          sys         idle          irq
       #1  2397 MHz      37361 s          0 s       1592 s      52933 s          0 s
       #2  2397 MHz      50248 s          0 s       1524 s      40097 s          0 s
       
  Memory: 6.764884948730469 GB (3338.015625 MB free)
  Uptime: 935.0 sec
  Load Avg:  1.0107421875  1.0234375  0.73876953125
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-8.0.1 (ORCJIT, haswell)

Runtime information

Runtime Info
BLAS #threads 2
BLAS.vendor() openblas64
Sys.CPU_THREADS 2

lscpu output:

Architecture:        x86_64
CPU op-mode(s):      32-bit, 64-bit
Byte Order:          Little Endian
CPU(s):              2
On-line CPU(s) list: 0,1
Thread(s) per core:  1
Core(s) per socket:  2
Socket(s):           1
NUMA node(s):        1
Vendor ID:           GenuineIntel
CPU family:          6
Model:               63
Model name:          Intel(R) Xeon(R) CPU E5-2673 v3 @ 2.40GHz
Stepping:            2
CPU MHz:             2397.219
BogoMIPS:            4794.43
Hypervisor vendor:   Microsoft
Virtualization type: full
L1d cache:           32K
L1i cache:           32K
L2 cache:            256K
L3 cache:            30720K
NUMA node0 CPU(s):   0,1
Flags:               fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ss ht syscall nx pdpe1gb rdtscp lm constant_tsc rep_good nopl xtopology cpuid pni pclmulqdq ssse3 fma cx16 pcid sse4_1 sse4_2 movbe popcnt aes xsave avx f16c rdrand hypervisor lahf_lm abm invpcid_single pti fsgsbase bmi1 avx2 smep bmi2 erms invpcid xsaveopt md_clear
Cpu Property Value
Brand Intel(R) Xeon(R) CPU E5-2673 v3 @ 2.40GHz
Vendor :Intel
Architecture :Haswell
Model Family: 0x06, Model: 0x3f, Stepping: 0x02, Type: 0x00
Cores 2 physical cores, 2 logical cores (on executing CPU)
No Hyperthreading detected
Clock Frequencies Not supported by CPU
Data Cache Level 1:3 : (32, 256, 30720) kbytes
64 byte cache line size
Address Size 48 bits virtual, 44 bits physical
SIMD 256 bit = 32 byte max. SIMD vector size
Time Stamp Counter TSC is accessible via rdtsc
TSC increased at every clock cycle (non-invariant TSC)
Perf. Monitoring Performance Monitoring Counters (PMC) are not supported
Hypervisor Yes, Microsoft

@github-actions
Copy link
Contributor

Multi-thread benchmark result

Judge result

Benchmark Report for /home/runner/work/Transducers.jl/Transducers.jl

Job Properties

  • Time of benchmarks:
    • Target: 23 Jun 2020 - 01:20
    • Baseline: 23 Jun 2020 - 01:25
  • Package commits:
    • Target: 510cf7
    • Baseline: ff8ec3
  • Julia commits:
    • Target: 44fa15
    • Baseline: 44fa15
  • Julia command flags:
    • Target: None
    • Baseline: None
  • Environment variables:
    • Target: JULIA_NUM_THREADS => 2
    • Baseline: JULIA_NUM_THREADS => 2

Results

A ratio greater than 1.0 denotes a possible regression (marked with ❌), while a ratio less
than 1.0 denotes a possible improvement (marked with ✅). Only significant results - results
that indicate possible regressions or improvements - are shown below (thus, an empty table means that all
benchmark results remained invariant between builds).

ID time ratio memory ratio
["collect", "seq"] 1.05 (5%) ❌ 1.00 (1%)
["findfirst", "n=400", "foldl"] 1.06 (5%) ❌ 1.00 (1%)
["findfirst", "n=500", "foldl"] 1.05 (5%) ❌ 1.00 (1%)
["findfirst", "n=500", "reduce", "basesize=256"] 1.03 (5%) 0.99 (1%) ✅
["findfirst", "n=500", "reduce", "basesize=512"] 1.07 (5%) ❌ 0.97 (1%) ✅
["overhead", "stoppable=true"] 1.07 (5%) ❌ 1.00 (1%)
["parallel_histogram", "comm", "basesize=4096"] 0.95 (5%) ✅ 0.98 (1%) ✅
["parallel_histogram", "comm", "basesize=8192"] 1.21 (5%) ❌ 1.01 (1%) ❌
["sum", "random", "foldl"] 1.10 (5%) ❌ 1.00 (1%)
["sum", "random", "reduce", "basesize=512"] 1.11 (5%) ❌ 0.99 (1%)
["sum", "uniform", "foldl"] 0.94 (5%) ✅ 1.00 (1%)
["sum", "valley", "foldl"] 0.94 (5%) ✅ 1.00 (1%)
["words", "nthreads=2"] 0.93 (5%) ✅ 1.01 (1%)

Benchmark Group List

Here's a list of all the benchmark groups executed by this job:

  • ["collect", "assoc"]
  • ["collect"]
  • ["collect", "unordered"]
  • ["findfirst", "n=1000"]
  • ["findfirst", "n=1000", "reduce"]
  • ["findfirst", "n=400"]
  • ["findfirst", "n=400", "reduce"]
  • ["findfirst", "n=500"]
  • ["findfirst", "n=500", "reduce"]
  • ["overhead"]
  • ["parallel_histogram", "assoc"]
  • ["parallel_histogram", "comm"]
  • ["parallel_histogram"]
  • ["sum", "random"]
  • ["sum", "random", "reduce"]
  • ["sum", "uniform"]
  • ["sum", "uniform", "reduce"]
  • ["sum", "valley"]
  • ["sum", "valley", "reduce"]
  • ["words"]

Julia versioninfo

Target

Julia Version 1.4.2
Commit 44fa15b150* (2020-05-23 18:35 UTC)
Platform Info:
  OS: Linux (x86_64-pc-linux-gnu)
      Ubuntu 18.04.4 LTS
  uname: Linux 5.3.0-1028-azure #29~18.04.1-Ubuntu SMP Fri Jun 5 14:32:34 UTC 2020 x86_64 x86_64
  CPU: Intel(R) Xeon(R) CPU E5-2673 v4 @ 2.30GHz: 
              speed         user         nice          sys         idle          irq
       #1  2294 MHz      44526 s          0 s       2507 s      78658 s          0 s
       #2  2294 MHz      54743 s          0 s       2981 s      68845 s          0 s
       
  Memory: 6.764884948730469 GB (3331.12890625 MB free)
  Uptime: 1279.0 sec
  Load Avg:  1.70703125  1.50146484375  0.8994140625
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-8.0.1 (ORCJIT, broadwell)

Baseline

Julia Version 1.4.2
Commit 44fa15b150* (2020-05-23 18:35 UTC)
Platform Info:
  OS: Linux (x86_64-pc-linux-gnu)
      Ubuntu 18.04.4 LTS
  uname: Linux 5.3.0-1028-azure #29~18.04.1-Ubuntu SMP Fri Jun 5 14:32:34 UTC 2020 x86_64 x86_64
  CPU: Intel(R) Xeon(R) CPU E5-2673 v4 @ 2.30GHz: 
              speed         user         nice          sys         idle          irq
       #1  2294 MHz      64986 s          0 s       3130 s      86904 s          0 s
       #2  2294 MHz      79344 s          0 s       3644 s      72864 s          0 s
       
  Memory: 6.764884948730469 GB (3398.26171875 MB free)
  Uptime: 1574.0 sec
  Load Avg:  1.716796875  1.56689453125  1.09228515625
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-8.0.1 (ORCJIT, broadwell)

Target result

Benchmark Report for /home/runner/work/Transducers.jl/Transducers.jl

Job Properties

  • Time of benchmark: 23 Jun 2020 - 1:20
  • Package commit: 510cf7
  • Julia commit: 44fa15
  • Julia command flags: None
  • Environment variables: JULIA_NUM_THREADS => 2

Results

Below is a table of this job's results, obtained by running the benchmarks.
The values listed in the ID column have the structure [parent_group, child_group, ..., key], and can be used to
index into the BaseBenchmarks suite to retrieve the corresponding benchmarks.
The percentages accompanying time and memory values in the below table are noise tolerances. The "true"
time/memory value for a given benchmark is expected to fall within this percentage of the reported value.
An empty cell means that the value was zero.

ID time GC time memory allocations
["collect", "assoc", "basesize=1"] 316.855 ms (5%) 11.165 ms 87.55 MiB (1%) 1590727
["collect", "assoc", "basesize=1024"] 168.779 ms (5%) 1.84 MiB (1%) 1812
["collect", "assoc", "basesize=32"] 176.271 ms (5%) 5.64 MiB (1%) 54011
["collect", "seq"] 341.149 ms (5%) 1.50 MiB (1%) 32787
["collect", "unordered", "basesize=1"] 397.890 ms (5%) 29.16 MiB (1%) 403223
["collect", "unordered", "basesize=1024"] 194.607 ms (5%) 777.55 KiB (1%) 2855
["collect", "unordered", "basesize=32"] 201.996 ms (5%) 1.46 MiB (1%) 16266
["findfirst", "n=1000", "foldl"] 547.400 ms (5%)
["findfirst", "n=1000", "reduce", "basesize=128"] 275.120 ms (5%) 564.06 KiB (1%) 10231
["findfirst", "n=1000", "reduce", "basesize=256"] 277.693 ms (5%) 287.11 KiB (1%) 5217
["findfirst", "n=1000", "reduce", "basesize=512"] 281.895 ms (5%) 149.19 KiB (1%) 2717
["findfirst", "n=400", "foldl"] 427.924 ms (5%)
["findfirst", "n=400", "reduce", "basesize=128"] 208.640 ms (5%) 1.02 MiB (1%) 18974
["findfirst", "n=400", "reduce", "basesize=256"] 212.601 ms (5%) 526.08 KiB (1%) 9569
["findfirst", "n=400", "reduce", "basesize=512"] 215.421 ms (5%) 267.14 KiB (1%) 4874
["findfirst", "n=500", "foldl"] 69.435 ms (5%)
["findfirst", "n=500", "reduce", "basesize=128"] 34.935 ms (5%) 157.38 KiB (1%) 2853
["findfirst", "n=500", "reduce", "basesize=256"] 35.495 ms (5%) 84.48 KiB (1%) 1533
["findfirst", "n=500", "reduce", "basesize=512"] 38.401 ms (5%) 48.20 KiB (1%) 876
["overhead", "default"] 178.000 μs (5%) 146.14 KiB (1%) 2628
["overhead", "stoppable=false"] 174.600 μs (5%) 146.16 KiB (1%) 2629
["overhead", "stoppable=true"] 308.400 μs (5%) 146.42 KiB (1%) 2646
["parallel_histogram", "assoc", "basesize=16384"] 3.609 ms (5%) 732.02 KiB (1%) 101
["parallel_histogram", "assoc", "basesize=4096"] 4.377 ms (5%) 1.80 MiB (1%) 495
["parallel_histogram", "assoc", "basesize=8192"] 4.009 ms (5%) 1.43 MiB (1%) 240
["parallel_histogram", "comm", "basesize=16384"] 13.639 ms (5%) 1.22 MiB (1%) 159
["parallel_histogram", "comm", "basesize=4096"] 19.487 ms (5%) 1.04 MiB (1%) 4521
["parallel_histogram", "comm", "basesize=8192"] 17.821 ms (5%) 1.24 MiB (1%) 1542
["parallel_histogram", "seq"] 6.271 ms (5%) 364.64 KiB (1%) 26
["sum", "random", "foldl"] 12.838 ms (5%)
["sum", "random", "reduce", "basesize=128"] 6.661 ms (5%) 313.33 KiB (1%) 6067
["sum", "random", "reduce", "basesize=256"] 6.428 ms (5%) 155.13 KiB (1%) 3013
["sum", "random", "reduce", "basesize=512"] 6.616 ms (5%) 76.30 KiB (1%) 1487
["sum", "uniform", "foldl"] 11.683 ms (5%)
["sum", "uniform", "reduce", "basesize=128"] 6.639 ms (5%) 313.36 KiB (1%) 6069
["sum", "uniform", "reduce", "basesize=256"] 6.474 ms (5%) 155.11 KiB (1%) 3012
["sum", "uniform", "reduce", "basesize=512"] 6.158 ms (5%) 76.27 KiB (1%) 1485
["sum", "valley", "foldl"] 11.998 ms (5%)
["sum", "valley", "reduce", "basesize=128"] 6.698 ms (5%) 313.28 KiB (1%) 6064
["sum", "valley", "reduce", "basesize=256"] 6.563 ms (5%) 155.09 KiB (1%) 3011
["sum", "valley", "reduce", "basesize=512"] 6.404 ms (5%) 76.25 KiB (1%) 1484
["words", "nthreads=1"] 37.297 ms (5%) 7.423 ms 65.23 MiB (1%) 2110715
["words", "nthreads=2"] 20.542 ms (5%) 65.95 MiB (1%) 2110869
["words", "nthreads=4"] 21.291 ms (5%) 66.40 MiB (1%) 2111016

Benchmark Group List

Here's a list of all the benchmark groups executed by this job:

  • ["collect", "assoc"]
  • ["collect"]
  • ["collect", "unordered"]
  • ["findfirst", "n=1000"]
  • ["findfirst", "n=1000", "reduce"]
  • ["findfirst", "n=400"]
  • ["findfirst", "n=400", "reduce"]
  • ["findfirst", "n=500"]
  • ["findfirst", "n=500", "reduce"]
  • ["overhead"]
  • ["parallel_histogram", "assoc"]
  • ["parallel_histogram", "comm"]
  • ["parallel_histogram"]
  • ["sum", "random"]
  • ["sum", "random", "reduce"]
  • ["sum", "uniform"]
  • ["sum", "uniform", "reduce"]
  • ["sum", "valley"]
  • ["sum", "valley", "reduce"]
  • ["words"]

Julia versioninfo

Julia Version 1.4.2
Commit 44fa15b150* (2020-05-23 18:35 UTC)
Platform Info:
  OS: Linux (x86_64-pc-linux-gnu)
      Ubuntu 18.04.4 LTS
  uname: Linux 5.3.0-1028-azure #29~18.04.1-Ubuntu SMP Fri Jun 5 14:32:34 UTC 2020 x86_64 x86_64
  CPU: Intel(R) Xeon(R) CPU E5-2673 v4 @ 2.30GHz: 
              speed         user         nice          sys         idle          irq
       #1  2294 MHz      44526 s          0 s       2507 s      78658 s          0 s
       #2  2294 MHz      54743 s          0 s       2981 s      68845 s          0 s
       
  Memory: 6.764884948730469 GB (3331.12890625 MB free)
  Uptime: 1279.0 sec
  Load Avg:  1.70703125  1.50146484375  0.8994140625
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-8.0.1 (ORCJIT, broadwell)

Baseline result

Benchmark Report for /home/runner/work/Transducers.jl/Transducers.jl

Job Properties

  • Time of benchmark: 23 Jun 2020 - 1:25
  • Package commit: ff8ec3
  • Julia commit: 44fa15
  • Julia command flags: None
  • Environment variables: JULIA_NUM_THREADS => 2

Results

Below is a table of this job's results, obtained by running the benchmarks.
The values listed in the ID column have the structure [parent_group, child_group, ..., key], and can be used to
index into the BaseBenchmarks suite to retrieve the corresponding benchmarks.
The percentages accompanying time and memory values in the below table are noise tolerances. The "true"
time/memory value for a given benchmark is expected to fall within this percentage of the reported value.
An empty cell means that the value was zero.

ID time GC time memory allocations
["collect", "assoc", "basesize=1"] 319.935 ms (5%) 14.029 ms 87.55 MiB (1%) 1590672
["collect", "assoc", "basesize=1024"] 175.210 ms (5%) 1.84 MiB (1%) 1825
["collect", "assoc", "basesize=32"] 180.712 ms (5%) 5.64 MiB (1%) 54022
["collect", "seq"] 324.802 ms (5%) 1.50 MiB (1%) 32787
["collect", "unordered", "basesize=1"] 395.443 ms (5%) 29.16 MiB (1%) 403220
["collect", "unordered", "basesize=1024"] 192.339 ms (5%) 777.50 KiB (1%) 2852
["collect", "unordered", "basesize=32"] 206.773 ms (5%) 1.48 MiB (1%) 17258
["findfirst", "n=1000", "foldl"] 540.834 ms (5%)
["findfirst", "n=1000", "reduce", "basesize=128"] 279.849 ms (5%) 565.28 KiB (1%) 10251
["findfirst", "n=1000", "reduce", "basesize=256"] 277.472 ms (5%) 288.44 KiB (1%) 5244
["findfirst", "n=1000", "reduce", "basesize=512"] 283.580 ms (5%) 150.55 KiB (1%) 2746
["findfirst", "n=400", "foldl"] 402.091 ms (5%)
["findfirst", "n=400", "reduce", "basesize=128"] 209.009 ms (5%) 1.02 MiB (1%) 18994
["findfirst", "n=400", "reduce", "basesize=256"] 208.060 ms (5%) 527.53 KiB (1%) 9604
["findfirst", "n=400", "reduce", "basesize=512"] 215.673 ms (5%) 268.50 KiB (1%) 4903
["findfirst", "n=500", "foldl"] 65.848 ms (5%)
["findfirst", "n=500", "reduce", "basesize=128"] 35.358 ms (5%) 158.59 KiB (1%) 2873
["findfirst", "n=500", "reduce", "basesize=256"] 34.568 ms (5%) 85.75 KiB (1%) 1556
["findfirst", "n=500", "reduce", "basesize=512"] 35.951 ms (5%) 49.45 KiB (1%) 898
["overhead", "default"] 184.099 μs (5%) 147.05 KiB (1%) 2646
["overhead", "stoppable=false"] 173.599 μs (5%) 146.22 KiB (1%) 2630
["overhead", "stoppable=true"] 287.299 μs (5%) 146.50 KiB (1%) 2649
["parallel_histogram", "assoc", "basesize=16384"] 3.715 ms (5%) 732.86 KiB (1%) 118
["parallel_histogram", "assoc", "basesize=4096"] 4.341 ms (5%) 1.80 MiB (1%) 512
["parallel_histogram", "assoc", "basesize=8192"] 3.983 ms (5%) 1.43 MiB (1%) 257
["parallel_histogram", "comm", "basesize=16384"] 13.781 ms (5%) 1.22 MiB (1%) 253
["parallel_histogram", "comm", "basesize=4096"] 20.605 ms (5%) 1.06 MiB (1%) 4501
["parallel_histogram", "comm", "basesize=8192"] 14.676 ms (5%) 1.23 MiB (1%) 569
["parallel_histogram", "seq"] 6.362 ms (5%) 364.64 KiB (1%) 26
["sum", "random", "foldl"] 11.675 ms (5%)
["sum", "random", "reduce", "basesize=128"] 6.724 ms (5%) 314.05 KiB (1%) 6078
["sum", "random", "reduce", "basesize=256"] 6.286 ms (5%) 155.84 KiB (1%) 3024
["sum", "random", "reduce", "basesize=512"] 5.984 ms (5%) 77.00 KiB (1%) 1497
["sum", "uniform", "foldl"] 12.458 ms (5%)
["sum", "uniform", "reduce", "basesize=128"] 6.761 ms (5%) 314.05 KiB (1%) 6078
["sum", "uniform", "reduce", "basesize=256"] 6.613 ms (5%) 155.84 KiB (1%) 3024
["sum", "uniform", "reduce", "basesize=512"] 6.368 ms (5%) 77.00 KiB (1%) 1497
["sum", "valley", "foldl"] 12.808 ms (5%)
["sum", "valley", "reduce", "basesize=128"] 6.720 ms (5%) 314.00 KiB (1%) 6075
["sum", "valley", "reduce", "basesize=256"] 6.643 ms (5%) 155.84 KiB (1%) 3024
["sum", "valley", "reduce", "basesize=512"] 6.445 ms (5%) 77.00 KiB (1%) 1497
["words", "nthreads=1"] 38.940 ms (5%) 7.505 ms 64.74 MiB (1%) 2094792
["words", "nthreads=2"] 22.044 ms (5%) 65.46 MiB (1%) 2094947
["words", "nthreads=4"] 21.930 ms (5%) 65.91 MiB (1%) 2095095

Benchmark Group List

Here's a list of all the benchmark groups executed by this job:

  • ["collect", "assoc"]
  • ["collect"]
  • ["collect", "unordered"]
  • ["findfirst", "n=1000"]
  • ["findfirst", "n=1000", "reduce"]
  • ["findfirst", "n=400"]
  • ["findfirst", "n=400", "reduce"]
  • ["findfirst", "n=500"]
  • ["findfirst", "n=500", "reduce"]
  • ["overhead"]
  • ["parallel_histogram", "assoc"]
  • ["parallel_histogram", "comm"]
  • ["parallel_histogram"]
  • ["sum", "random"]
  • ["sum", "random", "reduce"]
  • ["sum", "uniform"]
  • ["sum", "uniform", "reduce"]
  • ["sum", "valley"]
  • ["sum", "valley", "reduce"]
  • ["words"]

Julia versioninfo

Julia Version 1.4.2
Commit 44fa15b150* (2020-05-23 18:35 UTC)
Platform Info:
  OS: Linux (x86_64-pc-linux-gnu)
      Ubuntu 18.04.4 LTS
  uname: Linux 5.3.0-1028-azure #29~18.04.1-Ubuntu SMP Fri Jun 5 14:32:34 UTC 2020 x86_64 x86_64
  CPU: Intel(R) Xeon(R) CPU E5-2673 v4 @ 2.30GHz: 
              speed         user         nice          sys         idle          irq
       #1  2294 MHz      64986 s          0 s       3130 s      86904 s          0 s
       #2  2294 MHz      79344 s          0 s       3644 s      72864 s          0 s
       
  Memory: 6.764884948730469 GB (3398.26171875 MB free)
  Uptime: 1574.0 sec
  Load Avg:  1.716796875  1.56689453125  1.09228515625
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-8.0.1 (ORCJIT, broadwell)

Runtime information

Runtime Info
BLAS #threads 2
BLAS.vendor() openblas64
Sys.CPU_THREADS 2

lscpu output:

Architecture:        x86_64
CPU op-mode(s):      32-bit, 64-bit
Byte Order:          Little Endian
CPU(s):              2
On-line CPU(s) list: 0,1
Thread(s) per core:  1
Core(s) per socket:  2
Socket(s):           1
NUMA node(s):        1
Vendor ID:           GenuineIntel
CPU family:          6
Model:               79
Model name:          Intel(R) Xeon(R) CPU E5-2673 v4 @ 2.30GHz
Stepping:            1
CPU MHz:             2294.691
BogoMIPS:            4589.38
Hypervisor vendor:   Microsoft
Virtualization type: full
L1d cache:           32K
L1i cache:           32K
L2 cache:            256K
L3 cache:            51200K
NUMA node0 CPU(s):   0,1
Flags:               fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ss ht syscall nx pdpe1gb rdtscp lm constant_tsc rep_good nopl xtopology cpuid pni pclmulqdq ssse3 fma cx16 pcid sse4_1 sse4_2 movbe popcnt aes xsave avx f16c rdrand hypervisor lahf_lm abm 3dnowprefetch invpcid_single pti fsgsbase bmi1 hle avx2 smep bmi2 erms invpcid rtm rdseed adx smap xsaveopt
Cpu Property Value
Brand Intel(R) Xeon(R) CPU E5-2673 v4 @ 2.30GHz
Vendor :Intel
Architecture :Broadwell
Model Family: 0x06, Model: 0x4f, Stepping: 0x01, Type: 0x00
Cores 2 physical cores, 2 logical cores (on executing CPU)
No Hyperthreading detected
Clock Frequencies Not supported by CPU
Data Cache Level 1:3 : (32, 256, 51200) kbytes
64 byte cache line size
Address Size 48 bits virtual, 44 bits physical
SIMD 256 bit = 32 byte max. SIMD vector size
Time Stamp Counter TSC is accessible via rdtsc
TSC increased at every clock cycle (non-invariant TSC)
Perf. Monitoring Performance Monitoring Counters (PMC) are not supported
Hypervisor Yes, Microsoft

@mergify mergify bot merged commit 56ff2ee into master Jun 23, 2020
@mergify mergify bot deleted the fix-basecase-overhead branch June 23, 2020 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't spawn any tasks in reduce if basesize > length(itr)
1 participant