Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linear symplectic transformer #150

Merged
merged 94 commits into from
May 16, 2024
Merged

Conversation

benedict-96
Copy link
Collaborator

Includes an implementation of the linear symplectic transformer. Also added docs and reworked old docstrings and interfaces to math the new one:

  • renamed nhidden to n_layers (for SympNets) to better match the n_sympnet of the linear symplectic transformer
  • RegularTransformerIntegrator -> StandardTransformerIntegrator (as we have it in the paper); and everything except the first argument is a kwarg now.

There is now also an implementation of a theorem and a definition environment that works for both html and Latex.

Copy link

codecov bot commented May 15, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 22 lines in your changes are missing coverage. Please review.

Project coverage is 70.57%. Comparing base (14a9295) to head (8eecb10).

Files Patch % Lines
src/data_loader/data_loader.jl 0.00% 10 Missing ⚠️
src/arrays/symmetric.jl 0.00% 8 Missing ⚠️
src/map_to_cpu.jl 0.00% 2 Missing ⚠️
src/kernels/kernel_ad_routines/tensor_mat_mul.jl 0.00% 1 Missing ⚠️
...els/kernel_ad_routines/tensor_transpose_mat_mul.jl 90.90% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #150      +/-   ##
==========================================
+ Coverage   69.75%   70.57%   +0.81%     
==========================================
  Files         119      122       +3     
  Lines        3419     3473      +54     
==========================================
+ Hits         2385     2451      +66     
+ Misses       1034     1022      -12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@benedict-96 benedict-96 marked this pull request as draft May 15, 2024 09:30
@benedict-96 benedict-96 marked this pull request as ready for review May 15, 2024 12:40
@benedict-96 benedict-96 requested a review from michakraus May 15, 2024 12:40
@michakraus michakraus merged commit 8a2f2ef into main May 16, 2024
16 checks passed
@michakraus michakraus deleted the linear_symplectic_transformer branch May 16, 2024 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants