Sd/v05 #25
Sd/v05 #25
Conversation
| ) | ||
| end | ||
| end | ||
| if is_apple() |
There was a problem hiding this comment.
Did you mean @static if is_linux() as it's used above? Although I'm not sure if @static makes any difference in this case.
There was a problem hiding this comment.
Yeah, it shouldn't ;)
deps/deps.jl
Outdated
| @@ -0,0 +1,15 @@ | |||
| # This is an auto-generated file; do not edit | |||
There was a problem hiding this comment.
I guess this file has been added before editing .gitignore :)
deps/build.jl
Outdated
| end | ||
|
|
||
| @static if is_linux() | ||
| provides(AptGet, "libblas-dev", libCLBLAS) |
There was a problem hiding this comment.
This should be "libclblas-dev".
Also, we need to provide clear instructions how to build it: using apt-get requires root privileges, while Pkg.add is normally started without them.
|
@SimonDanisch not sure why it didn't update... but I've activated CI, build on master succeeds https://ci.maleadt.net/buildbot/julia/builders/CLBLAS.jl%3A%20Julia%200.5%20%28x86-64%29/builds/1 but fails on this PR https://ci.maleadt.net/buildbot/julia/builders/CLBLAS.jl%3A%20Julia%200.5%20%28x86-64%29/builds/2 EDIT: nvm, I know why it didn't push the status. Let me fix it. |
There was a problem hiding this comment.
Is CLBlas build with gcc or clang? You might be running into #23 on https://ci.maleadt.net/buildbot/julia/builders/CLBLAS.jl%3A%20Julia%20master%20%28x86-64%29/builds/7/steps/test/logs/stdio
Maybe we can't use Complex64 from base but rather have to figure out the correct size and layout...
| @@ -1,9 +1,9 @@ | |||
| import OpenCL | |||
| const cl = OpenCL | |||
| using OpenCL: cl | |||
|
I use the prebuild binaries installed with apt-get |
|
clblas binaries on my CI are the ones from GitHub too (Debian stable doesn't offer them). |
|
I'd like to leave the failures for another PR, since it should still be a strict improvement and it seems as if tests haven't been passing previously.... |
|
No objections from my side. I believe we should currently pay more attention to GPUArrays anyway, the future of CLBLAS heavily depends on it. I expect we will still link to libclblas in some way, but in the end bindings and installation procedure might be quite different. |
|
Great! |
|
I checked CLBLAS's master a week ago on my Ubuntu box and it worked perfectly well. I can check this PR's branch in the evening. |
|
Tests pass fine on this branch with CUDA and GeForce GTX 960M given that |
|
Okay, I think this should be ready to go! |
|
Tests for |
|
yeah they bring me a bit in a code duplication issue, since I now started to test them in GPUArrays... |
|
We still need to have some minimal tests here. But that shouldn't hold up
this PR.
…On Mon, 3 Apr 2017, 19:31 Simon, ***@***.***> wrote:
yeah they bring me a bit in a code duplication issue, since I now started
to test them in GPUArrays...
I guess the way forward is to rip all the high level stuff out of CLBLAS
and do testing etc in GPUArrays
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#25 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAI3aupZQVnV8BBpc_1Pd9tbnGI78WMeks5rsMqGgaJpZM4MFXQA>
.
|
|
sweet! :) |
Jeez, we really need to switch to defining unsafe_convert methods etc...