-
Notifications
You must be signed in to change notification settings - Fork 237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add EnzymeCore extension for parent_job #2281
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Marking as draft since the dependent PR hasn't been merged yet (to save on CI resources).
Okay this should be ready now. |
Looks like NNlib will need an EnzymeCore compat bump for CI to pass here (normally we detect installation issues of downstream packages and soft-fail that job, but here EnzymeCore is only a test dep so the failure happens during |
here's the NNlib bump: FluxML/NNlib.jl#571 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2281 +/- ##
==========================================
- Coverage 71.86% 71.84% -0.02%
==========================================
Files 155 155
Lines 15020 15022 +2
==========================================
- Hits 10794 10793 -1
- Misses 4226 4229 +3 ☔ View full report in Codecov by Sentry. |
This works for JuliaGPU/KernelAbstractions.jl#454 . Can we merge this? |
We need Enzyme.jl v0.12 to be released. Otherwise we make Enzyme and CUDA uninstallable together. |
Enzyme v0.12 is released Let me know if there's something I can do. |
@vchuravy these test failures seem unrelated. good to go? |
Yeah, the sorting failure is #2331. I've restarted the job. |
Co-authored-by: Tim Besard <[email protected]>
Alternative to #2260, depends on EnzymeAD/Enzyme.jl#1328