Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enzyme: allocation functions #2386

Merged
merged 13 commits into from
May 24, 2024
Merged

Enzyme: allocation functions #2386

merged 13 commits into from
May 24, 2024

Conversation

wsmoses
Copy link
Contributor

@wsmoses wsmoses commented May 17, 2024

No description provided.

@wsmoses wsmoses marked this pull request as draft May 17, 2024 08:19
@wsmoses wsmoses marked this pull request as ready for review May 17, 2024 13:59
@wsmoses
Copy link
Contributor Author

wsmoses commented May 17, 2024

@maleadt the 1.8 failure seems unrelated (and 1.9/1.10 seem to pass).

Mind giving it a review (and if all is well potentially backport)

@wsmoses
Copy link
Contributor Author

wsmoses commented May 20, 2024

@vchuravy @maleadt mind leaving a review?

@vchuravy
Copy link
Member

The downstream Enzyme test seems to be failing?

@wsmoses
Copy link
Contributor Author

wsmoses commented May 21, 2024

@vchuravy this seems to be the same issue from earlier:

"�_bk;t=1715973520023� LLVM error: Failed to materialize symbols: { (JuliaExternal, { libname_cuCtxGetApiVersion_44851, libname_cuMemAlloc_v2_45055, libname_cuCtxGetCurrent_44116, libname_cuDeviceGetName_44551, libname_cuCtxSetCurrent_44077, libname_cuCtxGetDevice_45018, libname_cuCtxPushCurrent_v2_45012, libname_cuStreamQuery_45023, libname_cuMemPoolCreate_44209, libname_cuCtxGetId_44849, libname_cuMemAllocFromPoolAsync_45053, libname_cuCtxSynchronize_44886, libname_cuCtxGetCurrent_44075, libname_cuCtxSynchronize_44880, augmented_julia_alloc_43860wrap, libname_cuMemAllocAsync_45045, libname_cudaRuntimeGetVersion_44545, libname_cuDeviceGetCount_44033, libname_cuMemAlloc_v2_45047, libname_cuDeviceSetMemPool_44203, libname_cuStreamCreate_44402, libname_cuStreamQuery_45024, libname_cuMemPoolTrimTo_44874, libname_cuCtxGetId_44124, libname_cuDeviceGetAttribute_44374, libname_cuStreamSynchronize_45077, libname_cuMemGetInfo_v2_44312, libname_cuMemPoolCreate_44110, libname_cuDeviceGet_44822, libname_cuMemPoolSetAttribute_44198, libname_cuStreamSynchronize_45072, libname_cuDevicePrimaryCtxRetain_44435, libname_cuMemPoolGetAttribute_44067, diffejulia_alloc_43860wrap, libname_cuCtxSetCurrent_44836, libname_cuCtxPopCurrent_v2_45015 }) }
"

@maleadt maleadt added the extensions Stuff about package extensions. label May 21, 2024
@maleadt
Copy link
Member

maleadt commented May 21, 2024

@vchuravy Feel free to merge when tests pass.

@wsmoses wsmoses closed this May 23, 2024
@wsmoses wsmoses reopened this May 23, 2024
@wsmoses
Copy link
Contributor Author

wsmoses commented May 24, 2024

@vchuravy @maleadt ah finally it passes. I'll make a backports PR as well

@maleadt maleadt merged commit cfe0ee5 into JuliaGPU:master May 24, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
extensions Stuff about package extensions.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants