Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CUBLAS: Don't use BLAS1 wrappers for strided arrays, only vectors. #2528

Merged
merged 1 commit into from
Oct 22, 2024

Conversation

maleadt
Copy link
Member

@maleadt maleadt commented Oct 22, 2024

These methods only take a single stride argument, so we can only use them with strided vectors, or dense arrays.

Fixes https://discourse.julialang.org/t/result-of-inner-product-of-two-cuarray-with-views-is-incorrect/121539

@maleadt maleadt added the cuda libraries Stuff about CUDA library wrappers. label Oct 22, 2024
Copy link

codecov bot commented Oct 22, 2024

Codecov Report

Attention: Patch coverage is 94.44444% with 1 line in your changes missing coverage. Please review.

Project coverage is 73.20%. Comparing base (50b953c) to head (45e6ff8).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
lib/cublas/linalg.jl 80.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #2528       +/-   ##
===========================================
+ Coverage   11.42%   73.20%   +61.77%     
===========================================
  Files         151      156        +5     
  Lines       14684    14983      +299     
===========================================
+ Hits         1678    10968     +9290     
+ Misses      13006     4015     -8991     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maleadt maleadt merged commit 14feb76 into master Oct 22, 2024
1 check passed
@maleadt maleadt deleted the tb/cublas_strided branch October 22, 2024 13:55
maleadt referenced this pull request Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cuda libraries Stuff about CUDA library wrappers.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant