Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Native RNG fixes for very large arrays #2561

Merged
merged 5 commits into from
Dec 11, 2024
Merged

Native RNG fixes for very large arrays #2561

merged 5 commits into from
Dec 11, 2024

Conversation

maleadt
Copy link
Member

@maleadt maleadt commented Nov 21, 2024

The overflow fix isn't great (sacrificing a couple of additional registers), and we probably have a bunch of similar bugs in other native kernels. I contemplated passing a typevar that determines the type of the counter, but that's additional complexity that's probably not worth it (e.g. in randn! the window size depends on the element type, so that would further couple kernel implementation details to the call site).

As noted by @thomasfaingnaert

@maleadt maleadt added cuda array Stuff about CuArray. bugfix This gets something working again. labels Nov 21, 2024
@maleadt maleadt enabled auto-merge November 21, 2024 16:24
@maleadt
Copy link
Member Author

maleadt commented Nov 22, 2024

base/random: Error During Test at /var/lib/buildkite-agent/builds/gpuci-14/julialang/cuda-dot-jl/test/base/random.jl:201
  Got exception outside of a @test
  Out of GPU memory trying to allocate 4.000 GiB
  Effective GPU memory usage: 99.82% (4.741 GiB/4.750 GiB)
  Memory pool usage: 16.000 KiB (3.188 GiB reserved)

Hmm, I wonder where that 1.6GiB of memory has gone...

@maleadt maleadt force-pushed the tb/rand branch 2 times, most recently from 2a05693 to acc31db Compare December 10, 2024 21:34
@maleadt maleadt disabled auto-merge December 11, 2024 15:50
@maleadt maleadt merged commit 860eb88 into master Dec 11, 2024
1 check failed
@maleadt maleadt deleted the tb/rand branch December 11, 2024 15:51
maleadt referenced this pull request Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix This gets something working again. cuda array Stuff about CuArray.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant