[CUSOLVER] Interface XsyevBatched #2577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtanneau
reviewed
Dec 6, 2024
There was a problem hiding this comment.
Thank you @amontoison! 🙏
I need to learn how to do this myself 🙃
| @testset "syevBatched!" begin | ||
| batch_size = 5 | ||
| for uplo in ('L', 'U') | ||
| (uplo == 'L') && (elty == ComplexF32) && continue |
There was a problem hiding this comment.
Should this have a @test_broken or something similar to avoid forgetting about it in the future?
There was a problem hiding this comment.
The issue is that one EVD in the batch randomly fails.
Maybe I should return an error directly in the function if someone wants to use it with this combinaison of parameters (uplo = 'L' and T = ComplexF32).
maleadt
force-pushed
the
cusolver_syevBatched
branch
from
c29a227 to
dfac79d
Compare
amontoison
force-pushed
the
cusolver_syevBatched
branch
from
b4813c1 to
2e38fc6
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2577 +/- ##
==========================================
+ Coverage 73.60% 73.65% +0.05%
==========================================
Files 156 156
Lines 15002 15030 +28
==========================================
+ Hits 11042 11071 +29
+ Misses 3960 3959 -1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requested by @mtanneau.
I found a bug with
uplo = 'L'and the precisionComplexF32, I should open a ticket.I commented the related tests.