Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add implementation notes to host functionality #401

Merged
merged 2 commits into from
Jun 20, 2023
Merged

Conversation

vchuravy
Copy link
Member

Specifies what is and what isn't mandated functionality.

Fixes #400

@vchuravy vchuravy requested review from pxl-th and maleadt June 16, 2023 17:58
@codecov
Copy link

codecov bot commented Jun 20, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +2.88 🎉

Comparison is base (606b2c5) 84.61% compared to head (a1e3f8a) 87.50%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #401      +/-   ##
==========================================
+ Coverage   84.61%   87.50%   +2.88%     
==========================================
  Files           7        8       +1     
  Lines         572      584      +12     
==========================================
+ Hits          484      511      +27     
+ Misses         88       73      -15     
Impacted Files Coverage Δ
src/KernelAbstractions.jl 83.33% <100.00%> (+4.58%) ⬆️

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@vchuravy vchuravy merged commit 5427d33 into main Jun 20, 2023
@vchuravy vchuravy deleted the vc/impl_notes branch June 20, 2023 22:45
@maleadt
Copy link
Member

maleadt commented Jun 21, 2023

Didn't realize this also included the fix. LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

KA seems to be broken for CUDA
2 participants