Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly adapt to ABI changes to EnzymeCore #476

Merged
merged 2 commits into from
May 11, 2024
Merged

Correctly adapt to ABI changes to EnzymeCore #476

merged 2 commits into from
May 11, 2024

Conversation

wsmoses
Copy link
Collaborator

@wsmoses wsmoses commented May 3, 2024

@wsmoses wsmoses requested a review from vchuravy May 3, 2024 22:10
@wsmoses
Copy link
Collaborator Author

wsmoses commented May 3, 2024

Require EnzymeAD/Enzyme.jl#1412 from our wonderfulness. Will patch bump Enzyme imminently

@vchuravy vchuravy closed this May 4, 2024
@vchuravy vchuravy reopened this May 4, 2024
@vchuravy
Copy link
Member

vchuravy commented May 4, 2024

That now segfaults

@wsmoses
Copy link
Collaborator Author

wsmoses commented May 4, 2024

Well that's both incredibly confusing and exciting (maybe we find [and fix] a previously unknown issue)

@vchuravy vchuravy merged commit 5b8a551 into main May 11, 2024
25 of 29 checks passed
@vchuravy vchuravy deleted the enzabi2 branch May 11, 2024 01:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants