Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix format suggestion formatting when diff contains "```" #534

Merged
merged 1 commit into from
Feb 6, 2025

Conversation

christiangnrd
Copy link
Contributor

Like when the diff contains "```".

See my edit to #418 (comment)

@christiangnrd christiangnrd changed the title Fix format suggstion formatting in some situations. Fix format suggestion formatting when diff contains "```" Feb 4, 2025
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Metal Benchmarks

Benchmark suite Current: dc065af Previous: ca092c8 Ratio
private array/construct 25055.5 ns 24829.916666666664 ns 1.01
private array/broadcast 458208 ns 458500 ns 1.00
private array/random/randn/Float32 929187.5 ns 798750 ns 1.16
private array/random/randn!/Float32 587875 ns 615041.5 ns 0.96
private array/random/rand!/Int64 548000 ns 563000 ns 0.97
private array/random/rand!/Float32 544875 ns 598021 ns 0.91
private array/random/rand/Int64 880709 ns 774083 ns 1.14
private array/random/rand/Float32 790229 ns 611583 ns 1.29
private array/copyto!/gpu_to_gpu 563042 ns 654250 ns 0.86
private array/copyto!/cpu_to_gpu 680583 ns 624208 ns 1.09
private array/copyto!/gpu_to_cpu 615541 ns 817708 ns 0.75
private array/accumulate/1d 1445250 ns 1329333 ns 1.09
private array/accumulate/2d 1509354 ns 1398375 ns 1.08
private array/iteration/findall/int 2341208 ns 2103583.5 ns 1.11
private array/iteration/findall/bool 2028291.5 ns 1824375 ns 1.11
private array/iteration/findfirst/int 1794583 ns 1688792 ns 1.06
private array/iteration/findfirst/bool 1746958 ns 1643000 ns 1.06
private array/iteration/scalar 2446041.5 ns 3772458 ns 0.65
private array/iteration/logical 3579583 ns 3187749.5 ns 1.12
private array/iteration/findmin/1d 1893000 ns 1760708 ns 1.08
private array/iteration/findmin/2d 1433604 ns 1344437.5 ns 1.07
private array/reductions/reduce/1d 929271 ns 1031583 ns 0.90
private array/reductions/reduce/2d 707459 ns 654750 ns 1.08
private array/reductions/mapreduce/1d 965416.5 ns 1033875 ns 0.93
private array/reductions/mapreduce/2d 716063 ns 659000 ns 1.09
private array/permutedims/4d 2652000 ns 2503500 ns 1.06
private array/permutedims/2d 1105542 ns 1028750 ns 1.07
private array/permutedims/3d 1799333.5 ns 1580708 ns 1.14
private array/copy 820250 ns 590270.5 ns 1.39
latency/precompile 8938431041 ns 8811389416 ns 1.01
latency/ttfp 3643834083 ns 3608628500 ns 1.01
latency/import 1252494125 ns 1231898292 ns 1.02
integration/metaldevrt 748145.5 ns 713792 ns 1.05
integration/byval/slices=1 1677000 ns 1617854.5 ns 1.04
integration/byval/slices=3 20242083 ns 9687812.5 ns 2.09
integration/byval/reference 1633875 ns 1589625 ns 1.03
integration/byval/slices=2 2842041.5 ns 2675542 ns 1.06
kernel/indexing 461750 ns 470792 ns 0.98
kernel/indexing_checked 472937.5 ns 463208 ns 1.02
kernel/launch 8000 ns 9527.666666666666 ns 0.84
metal/synchronization/stream 14708 ns 15125 ns 0.97
metal/synchronization/context 15167 ns 14834 ns 1.02
shared array/construct 26736.166666666668 ns 24604.166666666668 ns 1.09
shared array/broadcast 457708 ns 461166 ns 0.99
shared array/random/randn/Float32 915334 ns 738958.5 ns 1.24
shared array/random/randn!/Float32 593270.5 ns 633292 ns 0.94
shared array/random/rand!/Int64 555000 ns 561625 ns 0.99
shared array/random/rand!/Float32 552000 ns 600416 ns 0.92
shared array/random/rand/Int64 874291.5 ns 778375 ns 1.12
shared array/random/rand/Float32 804916 ns 616000 ns 1.31
shared array/copyto!/gpu_to_gpu 83292 ns 79250 ns 1.05
shared array/copyto!/cpu_to_gpu 83333 ns 82084 ns 1.02
shared array/copyto!/gpu_to_cpu 82833 ns 82750 ns 1.00
shared array/accumulate/1d 1441375 ns 1335833 ns 1.08
shared array/accumulate/2d 1519917 ns 1388833 ns 1.09
shared array/iteration/findall/int 2046896 ns 1871833 ns 1.09
shared array/iteration/findall/bool 1771458 ns 1569500 ns 1.13
shared array/iteration/findfirst/int 1517583 ns 1396916 ns 1.09
shared array/iteration/findfirst/bool 1432979.5 ns 1367500 ns 1.05
shared array/iteration/scalar 155708 ns 154834 ns 1.01
shared array/iteration/logical 3271708 ns 2987020.5 ns 1.10
shared array/iteration/findmin/1d 1589813 ns 1477062.5 ns 1.08
shared array/iteration/findmin/2d 1432604.5 ns 1364708 ns 1.05
shared array/reductions/reduce/1d 712020.5 ns 731750 ns 0.97
shared array/reductions/reduce/2d 706916 ns 666250 ns 1.06
shared array/reductions/mapreduce/1d 712583 ns 736667 ns 0.97
shared array/reductions/mapreduce/2d 697666.5 ns 672459 ns 1.04
shared array/permutedims/4d 2650667 ns 2493333 ns 1.06
shared array/permutedims/2d 1108042 ns 1024646 ns 1.08
shared array/permutedims/3d 1803708.5 ns 1576667 ns 1.14
shared array/copy 211042 ns 244000 ns 0.86

This comment was automatically generated by workflow using github-action-benchmark.

@christiangnrd christiangnrd merged commit ede2dfd into main Feb 6, 2025
6 checks passed
@christiangnrd christiangnrd deleted the christiangnrd-patch-1 branch February 6, 2025 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant