support pointefree mutables #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vchuravy
reviewed
Sep 21, 2017
src/kernel.jl
Outdated
| @@ -247,7 +247,7 @@ function set_arg!{T}(k::Kernel, idx::Integer, arg::T) | |||
| ref = if isbits(T_aligned) | |||
| Base.RefValue(packed) | |||
| else | |||
| packed | |||
| pointer_from_objref(packed) | |||
There was a problem hiding this comment.
Wouldn't it be fine to just say: Ref(packed)? and then let the logic for references take over instead of re-implementing it here?
There was a problem hiding this comment.
Yeah, that might just work...
There was a problem hiding this comment.
Do you want to quickly fix it otherwise I will merge this and tag a point release.
vchuravy
reviewed
Sep 21, 2017
test/test_behaviour.jl
Outdated
|
|
||
| end | ||
|
|
||
| mutable struct MutableParams |
There was a problem hiding this comment.
This won't work on 0.5. See test failure on GPU CI...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.