Additional fixes for Julia 1.0 support as well as failures on OpenCL 1.1 #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vchuravy
reviewed
Nov 4, 2018
vchuravy
approved these changes
Nov 4, 2018
|
Should we merge this? |
|
@SimonDanisch I was referring to #148. But I guess these changes are not related to those. So can be merged. |
|
Ok, thanks! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly a few fixes missed out in Julia 1.0 related fixes. Kernel attribute query which does not go well on OpenCL 1.1.
@SimonDanisch do you already have these changes in your radar? I see you already have a long WIP. I am seeing some issues with object layouts and it fails on my
AMD Radeon (TM) R7 M360 (ICELAND / DRM 3.23.0 / 4.15.0-36-generic, LLVM 6.0.0).