Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Versioned API v2 #49

Closed
wants to merge 16 commits into from
Closed

Versioned API v2 #49

wants to merge 16 commits into from

Conversation

jakebolewski
Copy link
Member

@vchuravy I'm even less sure of this after playing around with it some more. Do you have an example use case which would absolutely need this that I can have a look at? Using deprecated functions is really the only way to program with both a v1.1 and v1.2 platforms, and throwing warnings everywhere is really annoying. I think it would be better in the end to just do the checks at runtime around the functions we need this for. We could cache the query so the cost would be a dictionary lookup.

@jakebolewski jakebolewski changed the title Versioned API Versioned API v2 Aug 24, 2014
@vchuravy
Copy link
Member

So for me the main goal of this endeavour was to provide clean way to handle deprecation and changing OpenCL apis.

So for me the point was the @min_vXX family of macros and the deprecations where mainly about letting the developer (eg. our user) know that he should use them.

If we take away the whole deprecation part then we don't really need the conditional loading of API function and could remove that.

I still would like to keep the separation of the API into different files, because the previous @ocl_func_v11 was a bit opaque and splitting it up into different files make it a bit clearer.

I think you are right it might be best to rewrite the @min_vXX macros to use a dictionary with the platform id as keys so that it gets a cheap check.

I could prototype the other solution after Wednesday.

This was referenced Aug 27, 2014
@vchuravy
Copy link
Member

vchuravy commented Sep 5, 2014

superseded by #54

@vchuravy vchuravy closed this Sep 5, 2014
@vchuravy vchuravy deleted the jcb/versioned_api branch January 18, 2016 04:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants