-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Versioned API v2 #49
Versioned API v2 #49
Conversation
…sion - removes macros ocl_func_1_x - changes macro ocl_func to eval in modul context - import macro in each conitionally loaded file
… the ocl_func macro
So for me the main goal of this endeavour was to provide clean way to handle deprecation and changing OpenCL apis. So for me the point was the If we take away the whole deprecation part then we don't really need the conditional loading of API function and could remove that. I still would like to keep the separation of the API into different files, because the previous I think you are right it might be best to rewrite the I could prototype the other solution after Wednesday. |
superseded by #54 |
@vchuravy I'm even less sure of this after playing around with it some more. Do you have an example use case which would absolutely need this that I can have a look at? Using deprecated functions is really the only way to program with both a v1.1 and v1.2 platforms, and throwing warnings everywhere is really annoying. I think it would be better in the end to just do the checks at runtime around the functions we need this for. We could cache the query so the cost would be a dictionary lookup.