bugfix for LaplaceResult (#87)

* add test for laplace_steps
JuliaGaussianProcesses · Jan 10, 2022 · 5e475e3 · 5e475e3 · st-- · Jan 10, 2022
1 parent fee8c3d
commit 5e475e3
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 2 deletions.
diff --git a/Project.toml b/Project.toml
@@ -1,7 +1,7 @@
 name = "ApproximateGPs"
 uuid = "298c2ebc-0411-48ad-af38-99e88101b606"
 authors = ["JuliaGaussianProcesses Team"]
-version = "0.2.4"
+version = "0.2.5"
 
 [deps]
 AbstractGPs = "99985d1d-32ba-4be9-9821-2ec096f28918"

diff --git a/src/laplace.jl b/src/laplace.jl
@@ -348,7 +348,7 @@ function LaplaceResult(fnew, cache)
     q = MvNormal(f, AbstractGPs._symmetric(f_cov))
     lml_approx = _laplace_lml(f, cache)
 
-    return (; fnew, f_cov, q, lml_approx, cache...)
+    return (; fnew, f_cov, q, lml_approx, cache)
 end
 
 """

diff --git a/test/laplace.jl b/test/laplace.jl
@@ -246,4 +246,16 @@
             @test res_cold.minimizer ≈ res_warm.minimizer
         end
     end
+
+    @testset "laplace_steps" begin
+        X, Y = generate_data()
+        Random.seed!(123)
+        theta0 = rand(2)
+        lf = build_latent_gp(theta0)
+        lfx = lf(X)
+
+        res_array = ApproximateGPs.laplace_steps(lfx, Y)
+        res = res_array[end]
+        @test res.q isa MvNormal
+    end
 end