Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test JuliaGPsDocs on repo #124

Merged
merged 4 commits into from
Apr 2, 2022
Merged

Test JuliaGPsDocs on repo #124

merged 4 commits into from
Apr 2, 2022

Conversation

theogf
Copy link
Member

@theogf theogf commented Apr 1, 2022

Time for battle testing!

@theogf
Copy link
Member Author

theogf commented Apr 1, 2022

The errors seem unrelated to the PR...

@st--
Copy link
Member

st-- commented Apr 1, 2022

The errors seem unrelated to the PR...

Yes, my sincere apologies! Turns out AbstractGPs 0.5.10 was breaking after all 😞 @theogf once you've merged JuliaGaussianProcesses/AbstractGPs.jl#310 (& released) and #125, the build issues should be solely due to your own mistakes again ;)

docs/make.jl Outdated Show resolved Hide resolved
Copy link
Member

@st-- st-- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay! looks great. The only thing I'd prefer changed is for it not to be called "example.md".... is it not possible to have it by name.md as before? if it's got to be hardcoded I'd prefer index.md ...

@theogf
Copy link
Member Author

theogf commented Apr 1, 2022

Yay! looks great. The only thing I'd prefer changed is for it not to be called "example.md".... is it not possible to have it by name.md as before? if it's got to be hardcoded I'd prefer index.md ...

It is much easier to have a fixed name (this follow the same constraint as the "script.jl" thing. But sure we could go for another name

@theogf
Copy link
Member Author

theogf commented Apr 1, 2022

@devmotion was already using index.md, let's go with this then

docs/make.jl Outdated Show resolved Hide resolved
theogf and others added 2 commits April 1, 2022 22:18
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@codecov
Copy link

codecov bot commented Apr 2, 2022

Codecov Report

Merging #124 (2cfa705) into master (b4f17c3) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #124   +/-   ##
=======================================
  Coverage   93.30%   93.30%           
=======================================
  Files           4        4           
  Lines         284      284           
=======================================
  Hits          265      265           
  Misses         19       19           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b4f17c3...2cfa705. Read the comment docs.

@st--
Copy link
Member

st-- commented Apr 2, 2022

Seems to be working fine now. Great job @theogf 🎉

@theogf theogf merged commit d8510de into master Apr 2, 2022
@theogf theogf deleted the tgf/juliagpsdocs branch April 2, 2022 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants