-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test JuliaGPsDocs on repo #124
Conversation
The errors seem unrelated to the PR... |
Yes, my sincere apologies! Turns out AbstractGPs 0.5.10 was breaking after all 😞 @theogf once you've merged JuliaGaussianProcesses/AbstractGPs.jl#310 (& released) and #125, the build issues should be solely due to your own mistakes again ;) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yay! looks great. The only thing I'd prefer changed is for it not to be called "example.md".... is it not possible to have it by name.md as before? if it's got to be hardcoded I'd prefer index.md ...
It is much easier to have a fixed name (this follow the same constraint as the "script.jl" thing. But sure we could go for another name |
@devmotion was already using index.md, let's go with this then |
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…eGPs.jl into tgf/juliagpsdocs
Codecov Report
@@ Coverage Diff @@
## master #124 +/- ##
=======================================
Coverage 93.30% 93.30%
=======================================
Files 4 4
Lines 284 284
=======================================
Hits 265 265
Misses 19 19 Continue to review full report at Codecov.
|
Seems to be working fine now. Great job @theogf 🎉 |
Time for battle testing!