Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Flux.Adam instead of Flux.ADAM #136

Merged
merged 1 commit into from
Aug 9, 2022
Merged

Use Flux.Adam instead of Flux.ADAM #136

merged 1 commit into from
Aug 9, 2022

Conversation

simsurace
Copy link
Member

Fixes a deprecation warning.

Side note: there seem to be some new failures of SVA due to upstream changes.

@codecov
Copy link

codecov bot commented Aug 9, 2022

Codecov Report

Merging #136 (e4e1de4) into master (a9c3ecd) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #136   +/-   ##
=======================================
  Coverage   93.33%   93.33%           
=======================================
  Files           4        4           
  Lines         285      285           
=======================================
  Hits          266      266           
  Misses         19       19           

Help us with your feedback. Take ten seconds to tell us how you rate us.

Copy link
Member

@willtebbutt willtebbutt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the fix.

@willtebbutt
Copy link
Member

Will merge when CI completes

@willtebbutt willtebbutt merged commit 23ceaf7 into JuliaGaussianProcesses:master Aug 9, 2022
@simsurace simsurace deleted the ss/fix_adam_deprecation branch August 9, 2022 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants