Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CompatHelper: bump compat for IrrationalConstants to 0.2, (keep existing compat) #142

Conversation

github-actions[bot]
Copy link
Contributor

This pull request changes the compat entry for the IrrationalConstants package from 0.1 to 0.1, 0.2.
This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.

@rossviljoen rossviljoen force-pushed the compathelper/new_version/2023-02-21-01-23-57-091-03071871531 branch from fa65b36 to 0f61c47 Compare February 21, 2023 01:24
@codecov
Copy link

codecov bot commented Feb 21, 2023

Codecov Report

Base: 93.35% // Head: 93.35% // No change to project coverage 👍

Coverage data is based on head (6d275f8) compared to base (4ff9f30).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #142   +/-   ##
=======================================
  Coverage   93.35%   93.35%           
=======================================
  Files           4        4           
  Lines         286      286           
=======================================
  Hits          267      267           
  Misses         19       19           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@willtebbutt
Copy link
Member

compathelper isn't running on GPLikelihoods. Have re-enabled the workflow and will process updates

@willtebbutt willtebbutt reopened this Feb 23, 2023
@willtebbutt willtebbutt requested review from devmotion and removed request for devmotion February 23, 2023 15:25
Copy link
Member

@devmotion devmotion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests seem to use version 0.2.

@willtebbutt
Copy link
Member

Had to bump patch version. Will merge when CI passes

@willtebbutt willtebbutt merged commit 82999e6 into master Feb 23, 2023
@willtebbutt willtebbutt deleted the compathelper/new_version/2023-02-21-01-23-57-091-03071871531 branch February 23, 2023 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants