Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade codecov action to v2 #63

Merged
merged 1 commit into from
Sep 30, 2021
Merged

Upgrade codecov action to v2 #63

merged 1 commit into from
Sep 30, 2021

Conversation

rossviljoen
Copy link
Collaborator

@st--
Copy link
Member

st-- commented Sep 30, 2021

Still not working unfortunately, though now with a different error message:

[2021-09-30T12:35:03.165Z] ['info'] Pinging Codecov: https://codecov.io/upload/v4?package=github-action-2.1.0-uploader-0.1.2&token=*******&branch=ross%2Fcodecov-fix&build=1291013778&build_url=https%3A%2F%2Fgithub.com%2FJuliaGaussianProcesses%2FApproximateGPs.jl%2Factions%2Fruns%2F1291013778&commit=bc4424a09cd3dd7f81bdcbd3cc55668a3e305474&job=CI&pr=63&service=github-actions&slug=JuliaGaussianProcesses%2FApproximateGPs.jl&name=&tag=&flags=&parent=
[2021-09-30T12:35:03.477Z] ['error'] Error POSTing to https://codecov.io: 404 {'detail': ErrorDetail(string='Could not find a repository, try using repo upload token', code='not_found')}
[2021-09-30T12:35:03.477Z] ['error'] There was an error running the uploader: Error uploading to https://codecov.io: Error: Not Found

Copy link
Member

@st-- st-- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not solve the underlying issue - @rossviljoen just found out that this is due to the repo rename, see https://codecov.freshdesk.com/support/solutions/articles/43000629044-repo-not-updating-after-transfer-rename - so will have to be sorted out separately. Regardless, upgrading to v2 is the right thing to do (v1 is being sunset), so let's merge it in.

@st-- st-- changed the title Fix codecov Upgrade codecov action to v2 Sep 30, 2021
@codecov
Copy link

codecov bot commented Sep 30, 2021

Codecov Report

Merging #63 (bc4424a) into master (7c5c5c7) will decrease coverage by 1.78%.
The diff coverage is 86.81%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #63      +/-   ##
==========================================
- Coverage   88.77%   86.99%   -1.79%     
==========================================
  Files           3        5       +2     
  Lines          98      246     +148     
==========================================
+ Hits           87      214     +127     
- Misses         11       32      +21     
Impacted Files Coverage Δ
src/expected_loglik.jl 86.11% <86.11%> (ø)
src/laplace.jl 86.89% <86.89%> (ø)
src/elbo.jl 82.35% <100.00%> (-5.65%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3591bd2...bc4424a. Read the comment docs.

@rossviljoen
Copy link
Collaborator Author

The rename issue is now fixed as well

@rossviljoen rossviljoen merged commit d398b73 into master Sep 30, 2021
@rossviljoen rossviljoen deleted the ross/codecov-fix branch September 30, 2021 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants