Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add comment #68

Merged
merged 2 commits into from
Nov 4, 2021
Merged

Add comment #68

merged 2 commits into from
Nov 4, 2021

Conversation

willtebbutt
Copy link
Member

@willtebbutt willtebbutt commented Nov 4, 2021

Addresses #67

@willtebbutt willtebbutt requested a review from theogf November 4, 2021 16:14
@codecov
Copy link

codecov bot commented Nov 4, 2021

Codecov Report

Merging #68 (948912b) into master (d398b73) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #68   +/-   ##
=======================================
  Coverage   86.99%   86.99%           
=======================================
  Files           5        5           
  Lines         246      246           
=======================================
  Hits          214      214           
  Misses         32       32           
Impacted Files Coverage Δ
src/svgp.jl 93.18% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d398b73...948912b. Read the comment docs.

@theogf
Copy link
Member

theogf commented Nov 4, 2021

BTW any reason SVGP is not an AbstractGP ?

@st--
Copy link
Member

st-- commented Nov 4, 2021

BTW any reason SVGP is not an AbstractGP ?

Mhmm, I see it as more like LaplaceApproximation() than GP(). A way of specifying an approximation, not a GP in itself (the GP itself you get by calling posterior(...) on it)

@willtebbutt
Copy link
Member Author

willtebbutt commented Nov 4, 2021

Agreed @st-- . This might be a good candidate for re-naming though, because SVGP is literally "sparse variational Gaussian Process", which makes it sound an awful lot like it ought to be a GP. Perhaps we should go with something like SparseVariationalApproximation

@rossviljoen
Copy link
Collaborator

I'm in favour of renaming to SparseVariationalApproximation

@willtebbutt
Copy link
Member Author

Excellent. I've opened in a new issue so that we don't forget. @theogf is there anything else, or are you happy for this to approve?

@willtebbutt willtebbutt merged commit 812cfe0 into master Nov 4, 2021
@willtebbutt willtebbutt deleted the wct/comment branch November 4, 2021 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants