-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename SVGP
to SparseVariationalApproximation
#70
Conversation
SVGP
to StochasticVariationalApproximation
SVGP
to SparseVariationalApproximation
Actually - should it be |
This comment has been minimized.
This comment has been minimized.
While the S in SVGP is "Stochastic", in the context of "Approximation" I would prefer "Sparse". "Stochastic Approximation" seems to have an existing connotation with root finding/ optimization. |
We could then also add a (And I'm still very much looking forward to having an example of interdomain approximation:)) |
src/ApproximateGPs.jl
Outdated
@@ -15,10 +15,10 @@ using KLDivergences | |||
|
|||
using AbstractGPs: AbstractGP, FiniteGP, LatentFiniteGP, ApproxPosteriorGP, At_A, diag_At_A | |||
|
|||
export SVGP, DefaultQuadrature, Analytic, GaussHermite, MonteCarlo | |||
export SparseVariationalApproximation, DefaultQuadrature, Analytic, GaussHermite, MonteCarlo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a @deprecate SVGP SparseVariationalApproximation
somewhere (and we might have to keep the export here)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few minor comments - happy for you to merge directly after you've addressed them:)
NB- still needs a patch bump if you want to release it straight away |
The only thing I was worried about was that Even with the deprecation, this is still breaking right? so should be 0.2? @st-- |
No if we |
|
A true masterclass in find and replace
Closes #69