Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganise tests to match KernelFunctions #78

Merged
merged 5 commits into from
Nov 10, 2021
Merged

Conversation

rossviljoen
Copy link
Collaborator

Implements the suggestions in #75.

This doesn't change any tests or code - it only moves things around.

src/sparse_variational.jl Outdated Show resolved Hide resolved
test/laplace.jl Outdated Show resolved Hide resolved
test/laplace.jl Outdated Show resolved Hide resolved
test/laplace.jl Outdated Show resolved Hide resolved
test/laplace.jl Outdated Show resolved Hide resolved
test/laplace.jl Outdated Show resolved Hide resolved
test/laplace.jl Outdated Show resolved Hide resolved
test/laplace.jl Outdated Show resolved Hide resolved
rossviljoen and others added 3 commits November 9, 2021 22:54
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…sses/ApproximateGPs.jl into ross/reorganise-tests
@codecov
Copy link

codecov bot commented Nov 9, 2021

Codecov Report

Merging #78 (892ed5f) into master (122ff43) will not change coverage.
The diff coverage is 84.21%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #78   +/-   ##
=======================================
  Coverage   86.99%   86.99%           
=======================================
  Files           5        4    -1     
  Lines         246      246           
=======================================
  Hits          214      214           
  Misses         32       32           
Impacted Files Coverage Δ
src/sparse_variational.jl 89.83% <82.35%> (-3.36%) ⬇️
src/utils.jl 66.66% <100.00%> (+16.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 122ff43...892ed5f. Read the comment docs.

Copy link
Member

@willtebbutt willtebbutt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy with this. Could you please bump the patch version and tag a release, just on the off chance that something has actually changed.

@rossviljoen rossviljoen merged commit 675ab8a into master Nov 10, 2021
@rossviljoen rossviljoen deleted the ross/reorganise-tests branch November 10, 2021 18:32
@rossviljoen rossviljoen mentioned this pull request Nov 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants