fix SVGP deprecation: now gives Centered representation as it should have for backwards compatibility #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #95 +/- ##
=======================================
Coverage 95.69% 95.69%
=======================================
Files 4 4
Lines 279 279
=======================================
Hits 267 267
Misses 12 12 Continue to review full report at Codecov.
|
st--
requested review from
rossviljoen and
theogf
and removed request for
rossviljoen
theogf
approved these changes
Jan 17, 2022
st--
changed the title
st--
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #88
NB- https://github.com/JuliaGaussianProcesses/ApproximateGPs.jl/releases/tag/v0.2.2 was the one changing the default from Centered() to NonCentered() so should've been marked as breaking, whereas v0.2.0 didn't actually break anything (as there was the
@deprecate SVGP ...)...