Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix KernelFunctions on Julia 1.3 #554

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix KernelFunctions on Julia 1.3 #554

wants to merge 3 commits into from

Conversation

devmotion
Copy link
Member

#531 (included in KernelFunctions 0.10.62 and 0.10.63) broke KernelFunctions on Julia 1.3, which broke support and tests in downstream packages such as AbstractGPsMakie. The problem was that in CI the oldest supported Julia version was not tested.

I think it would be fine to drop support for Julia < 1.6 (even though I don't see the need as long as it works and does not impact development significantly) but before changing the Julia compat of KernelFunctions we have to fix support on Julia >= 1.3: Otherwise Pkg will always give people on such older Julia versions a broken KernelFunctions version (that currently can't even be loaded). Alternatively, we could mess with the registry and try to fix compat bounds retroactively but in my experience it's generally considered better practice to register bug fix releases than modifying existing releases (e.g. yanking a release can also break existing Manifest.toml files).

Copy link

codecov bot commented Mar 10, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 0.28%. Comparing base (874b026) to head (d905215).

Files with missing lines Patch % Lines
src/chainrules.jl 0.00% 2 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff           @@
##           master    #554   +/-   ##
======================================
  Coverage    0.28%   0.28%           
======================================
  Files          52      52           
  Lines        1421    1421           
======================================
  Hits            4       4           
  Misses       1417    1417           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@theogf
Copy link
Member

theogf commented Feb 3, 2025

@devmotion It looks like the errors on 1.3 are still relevant?

@willtebbutt
Copy link
Member

I would be strongly in favour of bumping our minimum required version to the current LTS release, 1.10.8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants