-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dont rebuild to GeometryBasics #137
Conversation
Is it now a "promise" that all |
Yep I will add here
Yes feel free to add such a method |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good to me!
I think its nice if users can pass in a module name and get those types back... but I'm not sure how easy it will be in practice because only GeoInterface geoms hold any trait compatible objects. Probably you are right it has to just be (And e.g. features might always need to use GI types) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! I think it is good that we have this be consistent. Better that users know what to expect. And I think it matches what LibGEOS does, which is to always return a LibGEOS polygon. So I think it is reasonable.
Should we release a new version with this fix? |
This removes all GeometryBasics
rebuild
customisation so that GI geometries are always returned.Fixes #133