Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable exotic array polygonization #143

Merged
merged 8 commits into from
May 16, 2024
Merged

Enable exotic array polygonization #143

merged 8 commits into from
May 16, 2024

Conversation

asinghvi17
Copy link
Member

@asinghvi17 asinghvi17 commented May 15, 2024 •
edited
Loading

  • Enable exotic array polygonization by propagating axis semantics to edge vectors (replaced explicit vector of tuples with similar(Vector{Tuple{...}}, xs)).
  • Propagate GI.crs(A) through to the output points, for Rasters
  • Test with OffsetArrays, DimensionalData, and Rasters
  • Try to fix Literate not detecting the comment in the source file

@asinghvi17 asinghvi17 changed the title Try to fix Literate not detecting the text properly Try to fix Literate not detecting the text properly in polygonize.jl May 15, 2024
asinghvi17 added 5 commits May 16, 2024 05:14
@asinghvi17
Add testing packages to extras
7136abc
@asinghvi17
Return edge vectors with the same axis semantics as axes(A)
686e760
@asinghvi17
Propagate CRS
e956574
@asinghvi17
Propagate extend to returned MultiPolygon for the Bool case
64814f2
@asinghvi17
Add exotic array tests for polygonize
558634e 
With the changes from the last commit, even Rasters work with roundtripped CRS.  The only thing remaining to be done is to figure out how to generate edge vectors for interval sampling, which would probably be an extension on Rasters in GeometryOps, since we're overriding an internal GO method.
@asinghvi17 asinghvi17 changed the title Try to fix Literate not detecting the text properly in polygonize.jl Enable exotic array polygonization May 15, 2024
@asinghvi17 asinghvi17 requested a review from rafaqz May 15, 2024 23:51
@asinghvi17 asinghvi17 mentioned this pull request May 16, 2024
Merged
rafaqz
rafaqz reviewed May 16, 2024
View reviewed changes
src/methods/polygonize.jl Outdated Show resolved Hide resolved
rafaqz
rafaqz reviewed May 16, 2024
View reviewed changes
src/methods/polygonize.jl Outdated Show resolved Hide resolved
rafaqz
rafaqz reviewed May 16, 2024
View reviewed changes
src/methods/polygonize.jl Outdated Show resolved Hide resolved
rafaqz
rafaqz approved these changes May 16, 2024
View reviewed changes
Copy link
Member

@rafaqz rafaqz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing PR title 🤌

@asinghvi17 asinghvi17 merged commit 5aff698 into fix_polygonize May 16, 2024
4 checks passed
@asinghvi17 asinghvi17 deleted the asinghvi17-patch-2 branch May 16, 2024 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rafaqz rafaqz rafaqz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@asinghvi17 @rafaqz