-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix typos #180
fix typos #180
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot, @spaette ! Hope you didn't have to do all of this by hand :)
The intention there was for the singular form so that works. |
The wording for area should probably read "computed differently for different geometry types" |
The work was based on dumped repo strings.
How about rewording as one of the following?
|
Go ahead and merge. src/methods/area.jl I'm leaving any debate on a possible rewrite to the Maintainers. Guess I'm not enthusiastic of |
Hmm, that makes sense. I am refactoring a bunch of stuff anyway so will sneak a rewrite in there. |
if the line is changed here's another attempt
one might want a potential rewrite to be suitable to both circumstances where the current line occurs
|
Is the intention
geometries'
orgeometry's
here?The pull has the typo fixed but the wording is a bit awkward here.