Skip to content

Commit

Permalink
Merge pull request #33 from j-fu/modernize
Browse files Browse the repository at this point in the history
Modernize: Formatting, fix named using, remove some superfluous files from stl dir, fix for 1.11 memory handling
  • Loading branch information
j-fu authored Nov 15, 2023
2 parents b7505cf + 181d78e commit e9934ed
Show file tree
Hide file tree
Showing 19 changed files with 788 additions and 12,921 deletions.
6 changes: 6 additions & 0 deletions .JuliaFormatter.toml
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
style = "sciml"
pipe_to_function_call=false
always_for_in = false
separate_kwargs_with_semicolon = true
margin = 132
yas_style_nesting=true
45 changes: 45 additions & 0 deletions .github/workflows/format_check.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,45 @@

name: format-check

on:
push:
branches:
- 'master'
- 'release-'
tags: '*'
pull_request:

jobs:
build:
runs-on: ${{ matrix.os }}
strategy:
matrix:
julia-version: [1.3.0]
julia-arch: [x86]
os: [ubuntu-latest]
steps:
- uses: julia-actions/setup-julia@latest
with:
version: ${{ matrix.julia-version }}

- uses: actions/checkout@v1
- name: Install JuliaFormatter and format
# This will use the latest version by default but you can set the version like so:
#
# julia -e 'using Pkg; Pkg.add(PackageSpec(name="JuliaFormatter", version="0.13.0"))'
run: |
julia -e 'using Pkg; Pkg.add(PackageSpec(name="JuliaFormatter"))'
julia -e 'using JuliaFormatter; format(".", verbose=true)'
- name: Format check
run: |
julia -e '
out = Cmd(`git diff --name-only`) |> read |> String
if out == ""
exit(0)
else
@error "Some files have not been formatted !!!"
write(stdout, out)
exit(1)
end'

4 changes: 2 additions & 2 deletions Project.toml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name = "TetGen"
uuid = "c5d3f3f7-f850-59f6-8a2e-ffc6dc1317ea"
authors = ["SimonDanisch <[email protected]>", "Juergen Fuhrmann <[email protected]"]
version = "1.4.0"
version = "1.5.0"

[deps]
DocStringExtensions = "ffbed154-4ef7-542d-bbb7-c09d3a79fcae"
Expand All @@ -15,8 +15,8 @@ TetGen_jll = "b47fdcd6-d2c1-58e9-bbba-c1cee8d8c179"
DocStringExtensions = "0.8,0.9"
GeometryBasics = "0.2, 0.3, 0.4"
StaticArrays = "1"
julia = "1.6"
TetGen_jll = "1.5.3"
julia = "1.6"

[extras]
Test = "8dfed614-e22c-5e08-85e1-65c5234f0b40"
Expand Down
3 changes: 3 additions & 0 deletions docs/Project.toml
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
[deps]
Documenter = "e30172f5-a6a5-5a46-863b-614d45cd2de4"
TetGen = "c5d3f3f7-f850-59f6-8a2e-ffc6dc1317ea"

[compat]
Documenter = "1"
25 changes: 12 additions & 13 deletions docs/make.jl
Original file line number Diff line number Diff line change
@@ -1,21 +1,20 @@
using Documenter, TetGen

function make_all()
makedocs(
makedocs(;
sitename = "TetGen.jl",
modules = [TetGen],
warnonly = true,
clean = false,
doctest = false,
authors = "Simon Danisch, Juergen Fuhrmann",
repo = "https://github.com/JuliaGeometry/TetGen.jl",
pages = [
"Home" => "index.md",
])

sitename="TetGen.jl",
modules = [TetGen],
clean = true,
doctest = false,
authors = "Simon Danisch, Juergen Fuhrmann",
repo="https://github.com/JuliaGeometry/TetGen.jl",
pages=[
"Home"=>"index.md"
]
)

if !isinteractive()
deploydocs(repo = "github.com/JuliaGeometry/TetGen.jl.git")
deploydocs(; repo = "github.com/JuliaGeometry/TetGen.jl.git")
end
end

Expand Down
4 changes: 4 additions & 0 deletions docs/src/index.md
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,10 @@ Modules = [TetGen]
Pages = [ "rawtetgenio.jl"]
```

```@docs
tetunsuitable!
```


## TetGen C++ code

Expand Down
Loading

2 comments on commit e9934ed

@j-fu
Copy link
Member Author

@j-fu j-fu commented on e9934ed Nov 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JuliaRegistrator
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Registration pull request created: JuliaRegistries/General/95372

Tip: Release Notes

Did you know you can add release notes too? Just add markdown formatted text underneath the comment after the text
"Release notes:" and it will be added to the registry PR, and if TagBot is installed it will also be added to the
release that TagBot creates. i.e.

@JuliaRegistrator register

Release notes:

## Breaking changes

- blah

To add them here just re-invoke and the PR will be updated.

Tagging

After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.

This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:

git tag -a v1.5.0 -m "<description of version>" e9934edffe3ecfd81555caec2c03ec7410da350b
git push origin v1.5.0

Please sign in to comment.