switch to Julia v0.7 #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 14, 2018
tkoolen
reviewed
Aug 16, 2018
.travis.yml
Outdated
| after_success: | ||
| # push coverage results to Coveralls | ||
| - julia -e 'cd(Pkg.dir("JSExpr")); Pkg.add("Coverage"); using Coverage; Coveralls.submit(Coveralls.process_folder())' |
There was a problem hiding this comment.
No need to import JSExpr here I don't think. It doesn't hurt though.
Codecov Report
@@ Coverage Diff @@
## master #16 +/- ##
======================================
+ Coverage 84.49% 90% +5.5%
======================================
Files 2 2
Lines 129 100 -29
======================================
- Hits 109 90 -19
+ Misses 20 10 -10
Continue to review full report at Codecov.
|
|
Ok, all green! |
|
Can I merge this and tag a release? |
|
Yes please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This involves more subtle macro expansion changes, as I think
@__MODULE__()is not exactly the same ascurrent_module(), but it does appear to work so far...Closes #12 (actually already fixed)