-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
conditionally use SpecialFunctions
through weak deps or Requires
#186
Conversation
SpecialFunctions
through weak deps or Requires
SpecialFunctions
through weak deps or Requires
SpecialFunctions
through weak deps or Requires
Codecov ReportBase: 86.41% // Head: 91.44% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #186 +/- ##
==========================================
+ Coverage 86.41% 91.44% +5.03%
==========================================
Files 2 3 +1
Lines 265 269 +4
==========================================
+ Hits 229 246 +17
+ Misses 36 23 -13
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Deep review comments 😆 below. I think this is a good idea. We need to make a breaking release soon anyway because we are way behind schedule on https://github.com/JuliaGraphics/ColorVectorSpace.jl#abs-and-abs2.
Thanks so much, @t-bltg! |
Fix #184.
Fix #182.
Fix last part of JuliaPlots/UnicodePlots.jl#291.
This is a proposal to make all the
SpecialFunctions
related functions (which are clearly piracy) optional using weak dependencies onjulia
>= 1.9 andRequires
on older releases.This would be (slightly) breaking so I guess we should bump
ColorVectorSpace
to0.10.0
if this PR is merged, since you'd have to use:to recover all the functionalities on current master.
Note that
lfact
is renamed tologfactorial
sincelfact
was deprecated inSpecialFunctions
.I followed the guidelines in https://pkgdocs.julialang.org/dev/creating-packages/#Conditional-loading-of-code-in-packages-(Extensions) and https://docs.julialang.org/en/v1.10-dev/manual/code-loading/#man-extensions.
This PR was written for
ColorSchemes
, andpkg> test ColorSchemes
passes locally sinceColorSchemes
does not depend on theSpecialFunctions
functionalities defined inColorVectorSpace
.Latency improvements:
PR
master
Ping @timholy or @kimikage or @johnnychen94 for review (primary contributors to this repo).