Speed up RGB <--> XYZ conversions again #410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #410 +/- ##
==========================================
+ Coverage 81.87% 81.95% +0.07%
==========================================
Files 11 11
Lines 883 892 +9
==========================================
+ Hits 723 731 +8
- Misses 160 161 +1
Continue to review full report at Codecov.
|
timholy
approved these changes
Mar 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was invented five months ago (cf. #351 (comment)), and Julia v1.3 was released in the meantime.
SIMD optimization is difficult in RGB <--> XYZ conversions. so this change has no dramatic improvement but is still effective.
closes #351.
Edit:
However, if we add the partial support for color gamuts in the near future (e.g. in v0.13), it is a good idea to leave this PR open, because the codes for gamma compression/expansion will be moved to a new file "gamuts.jl" (cf. #412)