Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for change to internal representation of methods #133

Merged
merged 2 commits into from
Mar 26, 2017

Conversation

ararslan
Copy link
Contributor

This PR adapts the internal get_args function for the recent change to AST compression in Base, introduced in JuliaLang/julia#20933.

@tkelman
Copy link
Contributor

tkelman commented Mar 25, 2017

that probably shouldn't have been merged during feature freeze if it's visible to package code...

@ararslan
Copy link
Contributor Author

ararslan commented Mar 26, 2017

Perhaps, though I imagine most packages don't do this level of introspection into methods.

@tkelman
Copy link
Contributor

tkelman commented Mar 26, 2017

DocStringExtensions also broke

@ararslan
Copy link
Contributor Author

Bummers.

@ararslan
Copy link
Contributor Author

@ararslan
Copy link
Contributor Author

So does this change look okay?

@tkelman tkelman merged commit b2e9baf into JuliaGraphics:master Mar 26, 2017
@ararslan ararslan deleted the aa/fix-0.6 branch March 26, 2017 06:43
@ararslan
Copy link
Contributor Author

Thanks! Any chance you could tag a new version?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants