Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hierarchical documentation structure #114

Merged
merged 13 commits into from
Mar 11, 2022
Merged

Hierarchical documentation structure #114

merged 13 commits into from
Mar 11, 2022

Conversation

gdalle
Copy link
Member

@gdalle gdalle commented Mar 9, 2022

Fixes #74

Main contributions:

  • Categorize documentation pages into: First steps, Graph types, Core functions, Algorithms, Advanced
  • Include all docstrings in the docs, each only once
  • Fix most documentation building bugs, so that the warnings / errors we get are actually informative
  • Clean up README and other Markdown files

@gdalle gdalle requested review from etiennedeg and matbesancon March 9, 2022 12:03
@etiennedeg
Copy link
Member

etiennedeg commented Mar 9, 2022

Many links do not exist anymore, notably url of the form docs/src/<problem>.md. These are replaced by docs/src/algorithms/<problem>.md. Maybe we should add redirection on these old links ?

@gdalle
Copy link
Member Author

gdalle commented Mar 9, 2022

Many links do not exist anymore, notably url of the form docs/src/<problem>.md. These are replaced by docs/src/algorithms/<problem>.md. Maybe we should add redirection on these old links ?

@etiennedeg what links are you referring to? Do you know a way to redirect without keeping a copy of these markdown files in the docs folder?

@codecov
Copy link

codecov bot commented Mar 9, 2022

Codecov Report

Merging #114 (962d8c8) into master (3628517) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #114   +/-   ##
=======================================
  Coverage   97.54%   97.54%           
=======================================
  Files         109      109           
  Lines        6318     6318           
=======================================
  Hits         6163     6163           
  Misses        155      155           

@etiennedeg
Copy link
Member

I think the urls such as https://juliagraphs.org/Graphs.jl/dev/pathing/ will no longer exist, and outside pages may still refer to the old version of the documentation, for example in discourse answers. Keeping a copy of these markdown files could work, but there is maybe a way to add redirection with Documenter.jl. Maybe there is some kind of policy for this in the Julia ecosystem, I don't know...

@gdalle
Copy link
Member Author

gdalle commented Mar 10, 2022

I see what you mean. Note however that we won't have this problem for links that refer to the stable documentation, it's only for those that choose to point to the dev version (which is a bold choice)

@gdalle
Copy link
Member Author

gdalle commented Mar 10, 2022

This could help in the long run JuliaDocs/Documenter.jl#1411.
But in the meantime, I think what we should do is create a custom 404 page using https://docs.github.com/en/pages/getting-started-with-github-pages/creating-a-custom-404-page-for-your-github-pages-site, saying something like

The URL you entered is incorrect. You may be trying to access an old version of the Graphs.jl documentation. For the latest version, go to...

@gdalle
Copy link
Member Author

gdalle commented Mar 11, 2022

@etiennedeg what do you think about an error message like this one: https://github.com/gdalle/Test404? Enough for the time being?

@etiennedeg
Copy link
Member

Yes, I don't think this is that much of an issue, don't spend much time on it if Documenter.jldoesn't provides 404 pages.

@gdalle
Copy link
Member Author

gdalle commented Mar 11, 2022

I'm not very familiar with the PR review process, how many approvals of JuliaGraphs members should I gather before I can merge?

@etiennedeg
Copy link
Member

Just one, I will take a look

@matbesancon
Copy link
Member

I am fine with the pages not existing anymore producing errors. People will then go back to the root and explore from there

@matbesancon
Copy link
Member

while we're at it @gdalle can you activate in this PR previews for the doc page? See https://juliadocs.github.io/Documenter.jl/stable/lib/public/#Documenter.deploydocs

@gdalle
Copy link
Member Author

gdalle commented Mar 11, 2022

while we're at it @gdalle can you activate in this PR previews for the doc page? See https://juliadocs.github.io/Documenter.jl/stable/lib/public/#Documenter.deploydocs

I could but it doesn't work for forks anyway so...

@gdalle
Copy link
Member Author

gdalle commented Mar 11, 2022

@etiennedeg I took your remarks into account, I also renamed the Graph types section into Ecosystem in case we want to expand it later. Go for merge as soon as the tests pass (or randomly fail on Windows / MacOS 😅) ?

Copy link
Member

@etiennedeg etiennedeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After that, I think we are good

Co-authored-by: Etienne dg <[email protected]>
@gdalle gdalle removed the request for review from matbesancon March 11, 2022 18:21
@gdalle gdalle merged commit 9650d3d into JuliaGraphs:master Mar 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Suggestion: Hierarchical structure for documentation
3 participants