-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hierarchical documentation structure #114
Conversation
Many links do not exist anymore, notably url of the form |
@etiennedeg what links are you referring to? Do you know a way to redirect without keeping a copy of these markdown files in the docs folder? |
Codecov Report
@@ Coverage Diff @@
## master #114 +/- ##
=======================================
Coverage 97.54% 97.54%
=======================================
Files 109 109
Lines 6318 6318
=======================================
Hits 6163 6163
Misses 155 155 |
I think the urls such as https://juliagraphs.org/Graphs.jl/dev/pathing/ will no longer exist, and outside pages may still refer to the old version of the documentation, for example in discourse answers. Keeping a copy of these markdown files could work, but there is maybe a way to add redirection with |
I see what you mean. Note however that we won't have this problem for links that refer to the stable documentation, it's only for those that choose to point to the dev version (which is a bold choice) |
This could help in the long run JuliaDocs/Documenter.jl#1411.
|
@etiennedeg what do you think about an error message like this one: https://github.com/gdalle/Test404? Enough for the time being? |
Yes, I don't think this is that much of an issue, don't spend much time on it if |
I'm not very familiar with the PR review process, how many approvals of JuliaGraphs members should I gather before I can merge? |
Just one, I will take a look |
I am fine with the pages not existing anymore producing errors. People will then go back to the root and explore from there |
while we're at it @gdalle can you activate in this PR previews for the doc page? See https://juliadocs.github.io/Documenter.jl/stable/lib/public/#Documenter.deploydocs |
Co-authored-by: Etienne dg <[email protected]>
I could but it doesn't work for forks anyway so... |
…x free file names)
@etiennedeg I took your remarks into account, I also renamed the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After that, I think we are good
Co-authored-by: Etienne dg <[email protected]>
Fixes #74
Main contributions: