Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cube Generator #33

Merged
merged 6 commits into from
Dec 23, 2020
Merged

Cube Generator #33

merged 6 commits into from
Dec 23, 2020

Conversation

mileslucas
Copy link
Member

@mileslucas mileslucas commented Dec 23, 2020

This updates the PSF injection, creating the useful CubeGenerator struct which helps bootstrap the process of creating many synthetic data cubes, such as for MLE.

This also removes the Kernels module in lieu of PSFModels.jl. No deprecations, but I have updated the semvar to indicate a breaking change.

An important change, too, is to use tuple/Polar instead of the keyword arguments for injecting. This generally simplifies the code, and when my Polard PR gets merged it will be even more usable.

@codecov
Copy link

codecov bot commented Dec 23, 2020

Codecov Report

Merging #33 (621ea29) into master (234c183) will decrease coverage by 4.66%.
The diff coverage is 73.84%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #33      +/-   ##
==========================================
- Coverage   86.36%   81.69%   -4.67%     
==========================================
  Files           9        9              
  Lines         374      306      -68     
==========================================
- Hits          323      250      -73     
- Misses         51       56       +5     
Flag Coverage Δ
unittests 81.69% <73.84%> (-4.67%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/HCIToolbox.jl 100.00% <ø> (ø)
src/inject.jl 70.83% <73.84%> (-16.04%) ⬇️
src/masking.jl 43.58% <0.00%> (-2.93%) ⬇️
src/geometry/multiannulus.jl 86.27% <0.00%> (-1.03%) ⬇️
src/scaling.jl 95.12% <0.00%> (-0.80%) ⬇️
src/geometry/annulus.jl 84.00% <0.00%> (-0.38%) ⬇️
src/angles.jl 100.00% <0.00%> (ø)
src/morphology.jl 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 234c183...f60d715. Read the comment docs.

@mileslucas mileslucas merged commit 9e0d116 into master Dec 23, 2020
@mileslucas mileslucas deleted the ml/cubegen branch December 23, 2020 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant