Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CompatHelper: bump compat for AMDGPU in [weakdeps] to 1 for package KomaMRICore, (keep existing compat) #460

Merged

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Aug 9, 2024

This pull request changes the compat entry for the AMDGPU package from 0.9 to 0.9, 1 for package KomaMRICore.
This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.

Copy link

codecov bot commented Aug 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.94%. Comparing base (a180ff5) to head (575a3a2).
Report is 3 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #460   +/-   ##
=======================================
  Coverage   90.94%   90.94%           
=======================================
  Files          53       53           
  Lines        2926     2926           
=======================================
  Hits         2661     2661           
  Misses        265      265           
Flag Coverage Δ
base 88.20% <ø> (ø)
core 92.69% <ø> (ø)
files 93.55% <ø> (ø)
komamri 93.98% <ø> (ø)
plots 89.30% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Contributor Author

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

KomaMRI Benchmarks

Benchmark suite Current: 575a3a2 Previous: dae2df1 Ratio
MRI Lab/Bloch/CPU/2 thread(s) 243020877 ns 225453139 ns 1.08
MRI Lab/Bloch/CPU/4 thread(s) 135285184.5 ns 135802285.5 ns 1.00
MRI Lab/Bloch/CPU/8 thread(s) 147069813 ns 145800343.5 ns 1.01
MRI Lab/Bloch/CPU/1 thread(s) 342461505 ns 347754103 ns 0.98
MRI Lab/Bloch/GPU/CUDA 57029771.5 ns 56476716 ns 1.01
MRI Lab/Bloch/GPU/oneAPI 513643081 ns 514499972 ns 1.00
MRI Lab/Bloch/GPU/Metal 545986167 ns 566912396 ns 0.96
MRI Lab/Bloch/GPU/AMDGPU 37058358 ns 36477480 ns 1.02
Slice Selection 3D/Bloch/CPU/2 thread(s) 1019258083 ns 1157077065 ns 0.88
Slice Selection 3D/Bloch/CPU/4 thread(s) 615555830 ns 624295507 ns 0.99
Slice Selection 3D/Bloch/CPU/8 thread(s) 387265452 ns 383113892 ns 1.01
Slice Selection 3D/Bloch/CPU/1 thread(s) 1938557912 ns 1930369445.5 ns 1.00
Slice Selection 3D/Bloch/GPU/CUDA 100701802 ns 101349123.5 ns 0.99
Slice Selection 3D/Bloch/GPU/oneAPI 648391225.5 ns 648132271.5 ns 1.00
Slice Selection 3D/Bloch/GPU/Metal 563120062.5 ns 563862104 ns 1.00
Slice Selection 3D/Bloch/GPU/AMDGPU 60910885 ns 60560585 ns 1.01

This comment was automatically generated by workflow using github-action-benchmark.

@cncastillo cncastillo merged commit 4d7519e into master Aug 20, 2024
19 checks passed
@cncastillo cncastillo deleted the compathelper/new_version/2024-08-09-00-40-44-455-03316379457 branch August 20, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant