Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing brain phantom values #465

Merged
merged 2 commits into from
Aug 20, 2024

Conversation

gsahonero
Copy link
Member

This PR is to fix #464

…006a)

Introducing Reproducibility notes into `brain_phantom2D`
Copy link

codecov bot commented Aug 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.03%. Comparing base (1b6c5be) to head (e74ae5b).
Report is 6 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #465      +/-   ##
==========================================
- Coverage   90.94%   87.03%   -3.91%     
==========================================
  Files          53       53              
  Lines        2926     2923       -3     
==========================================
- Hits         2661     2544     -117     
- Misses        265      379     +114     
Flag Coverage Δ
base 88.20% <ø> (ø)
core 71.18% <ø> (-21.52%) ⬇️
files 93.55% <ø> (ø)
komamri 93.98% <ø> (ø)
plots 89.30% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
KomaMRIBase/src/datatypes/Phantom.jl 85.10% <ø> (ø)

... and 7 files with indirect coverage changes

Copy link
Member

@cncastillo cncastillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Brainweb is already referenced in the documentation:

Creates a three-dimentional brain Phantom struct. Default ss=4 sample spacing is 2 mm. Original file (ss=1) sample spacing is .5 mm.

References

B. Aubert-Broche, D.L. Collins, A.C. Evans: "A new improved version of the realistic digital brain phantom" NeuroImage, in review - 2006
B. Aubert-Broche, M. Griffin, G.B. Pike, A.C. Evans and D.L. Collins: "20 new digital brain phantoms for creation of validation image data bases" IEEE TMI, in review - 2006
https://brainweb.bic.mni.mcgill.ca/brainweb

These are the parameters I used (Aubert-Broche, B. et al., 2006a)

https://github.com/JuliaHealth/KomaMRI.jl/blob/v0.1-alpha/src/data/Brain2DParameters.png
image

The 00 for the muscle must be a typo in the table. The skin value I could have changed on purpose (see JEMRIS's brain phantom).

Please check that phantom3D also has these changes.

Comment on lines 203 to 212
- Aubert-Broche, B., Alan C. Evans, and Louis Collins.
"A new improved version of the realistic digital brain phantom." NeuroImage 32, no. 1 (2006): 138-145. (Aubert-Broche, B. et al., 2006a)
- Aubert-Broche, B., Mark Griffin, G. Bruce Pike, Alan C. Evans, and D. Louis Collins.
"Twenty new digital brain phantoms for creation of validation image data bases." IEEE transactions on medical imaging 25, no. 11 (2006): 1410-1416. (Aubert-Broche, B. et al., 2006b)
- https://brainweb.bic.mni.mcgill.ca/brainweb/tissue_mr_parameters.txt (BrainWeb)

## Reproducibility notes
- T1, T2, T2* and PD Values for CSF, GM, WM, FAT, MUSCLE, SKIN/MUSCLE, SKULL, VESSELS, FAT2, DURA, MARROW are extracted from (Aubert-Broche, B. et al., 2006a)
- The T1 value for muscle is extracted from (Brainweb) as (Aubert-Broche, B. et al., 2006a) reports a 00 value.
- The T1 value of SKIN/MUSCLE is different between (BrainWeb) and (Aubert-Broche, B. et al., 2006a), we used the latter one.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove "Reproducibilty notes". Do not modify previous citations; just add more specific link to brainweb parameters.

Including required changes.
Copy link
Member Author

@gsahonero gsahonero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updates according to requested changes.

@cncastillo cncastillo merged commit dae2df1 into JuliaHealth:master Aug 20, 2024
16 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Brain phantom values inconsistencies
2 participants