-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support SharedArrays #463
support SharedArrays #463
Conversation
thx for the approval! |
lgmt. undefined and null tests are failing on windows any reason to suspect this PR? I don't think they were before |
egads. well, the "undefined and null" testset is where i inadvertently placed the test for this PR. do SharedArrays perhaps not work on windows? i can't test until monday as i only have access to a windows box at work. |
the problem appears to have nothing to do with SharedArrays, but rather that on windows:
vs. on OS X:
ideas why this would be the case? |
Even simpler # Windows behavior
julia> f1 = tempdir()*"adf.tmp"
"C:\\Users\\Mus\\AppData\\Local\\Temp\\adf.tmp"
julia> f2 = tempname()
"C:\\Users\\Mus\\AppData\\Local\\Temp\\jl_4E2F.tmp"
julia> ishdf5(f1)
true
julia> ishdf5(f2)
false
|
In the first case windows does not create the file |
is there a reason not to support SharedArrays? all this PR does is to use type
AbstractArray
instead ofArray
in select function signatures. includes a test.