Fix precompile condition to check for newer versions of julia #370
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The current condition
VERSION < v"0.7.0-beta2.199" && __precompile__()mistakenly allows the__precompile__()directive to be executed in older versions of Julia, which do not support it. This can lead to errors when using the package in Julia versions prior to 0.7.Solution
The condition has been updated to
VERSION >= v"0.7.0-beta2.199" && __precompile__()to ensure that__precompile__()is executed only in newer versions of Julia where it is supported.Impact
This fix ensures compatibility with older versions of Julia while maintaining functionality in newer versions. It prevents potential runtime errors for users on Julia 0.6 or earlier.