[WIP] Julia 1.0.0

[s-celles]

It's building
It's also working for my use case
but don't merge before discussing about these changes

[s-celles]

This is the kind of changes I have to do... but that I don't like

[s-celles]

same here...

Should it be Int32, Int8, Int16, Int64...

I'm pretty sure that we should be more "generic", getting underlying type of SPdtr at compile time.

I also did:

Int(dtr)

but I should have done

Integer(dtr)

For your information

julia> typeof(Int(SP_DTR_ON))
Int64

julia> typeof(Integer(SP_DTR_ON))
Int32

[andrewadare]

This is to address #17.

There are some changes that would be useful to include immediately, such as removing tic/toc, but I am less comfortable with other changes, such as casting the libserialport types to integers of various widths.

I'm going to leave this open for now, bringing in some of your changes manually (so this PR still definitely has value). We'd certainly like to be sure everything works properly with Julia 1.0 on 32 bit hosts such as a Raspberry Pi as well as on 64 bit systems.

[s-celles]

What we need to avoid to smear code like I did, is to be able to get the underlying type of an Enum.
Maybe @tanmaykm could give us a tip on this?

[s-celles]

@aviks could also help us on this

[andrewadare]

What we need to avoid to smear code like I did, is to be able to get the underlying type of an Enum.

I think adding constructors for the Enums in 03a0ff5 was sufficient to deal with the deprecation warnings/errors.

[s-celles]

Great idea! However I'm still wondering if the underlying type of an Enum can be known (for some others projects)

[andrewadare]

I may not be understanding what you're trying to do, but according to https://docs.julialang.org/en/stable/base/base/#Special-Types-1, the base type is Int32 by default:

BaseType, which defaults to Int32, must be a primitive subtype of Integer. Member values can be converted between the enum type and BaseType. read and write perform these conversions automatically.

[andrewadare]

This is kind of a silly example, but demonstrates the point:

using LibSerialPort

ret = SPReturn

for instance in instances(ret)
       println("$(typeof(instance)) $(supertype(typeof(instance)))")
end

SPReturn Enum{Int32}
SPReturn Enum{Int32}
SPReturn Enum{Int32}
SPReturn Enum{Int32}
SPReturn Enum{Int32}

[s-celles]

@enum Fruit::UInt8 apple orange kiwi

is allowed but how to get UInt8 from Fruit?

[andrewadare]

This is apparently one way:

julia> supertype(Fruit).parameters[1]
UInt8

[tanmaykm]

Another way could be:

julia> Base.Enums.basetype(Fruit)
UInt8

[s-celles]

Thanks @tanmaykm however I opened an issue at JuliaLang/julia#28778 because I think there is a room for improvement (at least for doc)