test closing removes mark

JuliaIO · Mar 31, 2024 · d514eb8 · d514eb8
1 parent 13dec86
commit d514eb8
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 2 deletions.
diff --git a/src/stream.jl b/src/stream.jl
@@ -231,7 +231,7 @@ end
 
 function Base.ismarked(stream::TranscodingStream)::Bool
     checkmode(stream)
-    ismarked(stream.buffer1)
+    isopen(stream) && ismarked(stream.buffer1)
 end
 
 function Base.mark(stream::TranscodingStream)::Int64
@@ -242,7 +242,7 @@ end
 
 function Base.unmark(stream::TranscodingStream)::Bool
     checkmode(stream)
-    unmark!(stream.buffer1)
+    isopen(stream) && unmark!(stream.buffer1)
 end
 
 function Base.reset(stream::T) where T<:TranscodingStream

diff --git a/test/codecnoop.jl b/test/codecnoop.jl
@@ -71,7 +71,9 @@
     @test unmark(stream)
     @test !ismarked(stream)
     @test !unmark(stream)
+    @test mark(stream) == 3
     close(stream)
+    @test !ismarked(stream)
 
     stream = TranscodingStream(Noop(), IOBuffer(b"foobarbaz"))
     @test stream == seek(stream, 2)

diff --git a/test/codecquadruple.jl b/test/codecquadruple.jl
@@ -143,7 +143,11 @@ end
             end
             @test mark(stream) == mark(iob)
             @test Base.reset(stream) == Base.reset(iob)
+            @test mark(stream) == mark(iob)
             close(stream)
+            close(iob)
+            @test !ismarked(stream)
+            @test !ismarked(iob)
         end
     end